epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #11871 from pchote/fix-production-circle

Browse Source 
Remove hardcoded constants from Fly and ProductionAirdrop.
This commit is contained in:
Matthias Mailänder
2016-08-27 19:43:15 +02:00
committed by GitHub
parent 7ac5a25ce6 06ca8b6cf2
commit 020b0e628e
2 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
OpenRA.Mods.Common/Activities/Air/Fly.cs
View File

@@ -66,9 +66,11 @@ namespace OpenRA.Mods.Common.Activities
if (insideMaxRange && !insideMinRange)
return NextActivity;
// Close enough (ported from old code which checked length against sqrt(50) px)
var d = target.CenterPosition - self.CenterPosition;
if (d.HorizontalLengthSquared < 91022)
// The next move would overshoot, so consider it close enough
var move = plane.FlyStep(plane.Facing);
if (d.HorizontalLengthSquared < move.HorizontalLengthSquared)
return NextActivity;
// Don't turn until we've reached the cruise altitude