From 02898e8bbce2f0e6a52088a4ceb020185a45e36d Mon Sep 17 00:00:00 2001 From: Paul Chote Date: Sat, 30 Mar 2013 17:04:50 +1300 Subject: [PATCH] Remove unnecessary trait lookup from DebugMuzzlePositions. --- OpenRA.Mods.RA/DebugMuzzlePositions.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/OpenRA.Mods.RA/DebugMuzzlePositions.cs b/OpenRA.Mods.RA/DebugMuzzlePositions.cs index 8da1e78d5d..931561a00b 100755 --- a/OpenRA.Mods.RA/DebugMuzzlePositions.cs +++ b/OpenRA.Mods.RA/DebugMuzzlePositions.cs @@ -28,15 +28,19 @@ namespace OpenRA.Mods.RA public class DebugFiringOffsets : IPostRender { Lazy> armaments; + DeveloperMode devMode; public DebugFiringOffsets(Actor self) { armaments = Lazy.New(() => self.TraitsImplementing()); + + var localPlayer = self.World.LocalPlayer; + devMode = localPlayer != null ? localPlayer.PlayerActor.Trait() : null; } public void RenderAfterWorld(WorldRenderer wr, Actor self) { - if (self.World.LocalPlayer == null || !self.World.LocalPlayer.PlayerActor.Trait().ShowMuzzles) + if (devMode == null || !devMode.ShowMuzzles) return; var wlr = Game.Renderer.WorldLineRenderer;