From 02f41f9afca03ac997c6a5686dee81f30348d637 Mon Sep 17 00:00:00 2001 From: Paul Chote Date: Wed, 25 Mar 2020 23:17:18 +0000 Subject: [PATCH] Fix SpriteEffect updating twice in the first tick. --- OpenRA.Mods.Common/Effects/SpriteEffect.cs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/OpenRA.Mods.Common/Effects/SpriteEffect.cs b/OpenRA.Mods.Common/Effects/SpriteEffect.cs index f1ffec39a8..aa4ff5d0c8 100644 --- a/OpenRA.Mods.Common/Effects/SpriteEffect.cs +++ b/OpenRA.Mods.Common/Effects/SpriteEffect.cs @@ -62,16 +62,18 @@ namespace OpenRA.Mods.Common.Effects world.ScreenMap.Add(this, pos, anim.Image); initialized = true; } + else + { + anim.Tick(); - anim.Tick(); - - pos = posFunc(); - world.ScreenMap.Update(this, pos, anim.Image); + pos = posFunc(); + world.ScreenMap.Update(this, pos, anim.Image); + } } public IEnumerable Render(WorldRenderer wr) { - if (!visibleThroughFog && world.FogObscures(pos)) + if (!initialized || (!visibleThroughFog && world.FogObscures(pos))) return SpriteRenderable.None; return anim.Render(pos, wr.Palette(palette));