check the cheap bool before expensive trait lookups

This commit is contained in:
Matthias Mailänder
2016-01-24 13:52:44 +01:00
parent 6b008a1b71
commit 03590b13cc

View File

@@ -765,7 +765,7 @@ namespace OpenRA.Mods.Common.AI
{ {
var allEnemyBaseBuilder = FindEnemyConstructionYards(); var allEnemyBaseBuilder = FindEnemyConstructionYards();
var ownUnits = activeUnits var ownUnits = activeUnits
.Where(unit => unit.Info.HasTraitInfo<AttackBaseInfo>() && !unit.Info.HasTraitInfo<AircraftInfo>() && unit.IsIdle).ToList(); .Where(unit => unit.IsIdle && unit.Info.HasTraitInfo<AttackBaseInfo>() && !unit.Info.HasTraitInfo<AircraftInfo>()).ToList();
if (!allEnemyBaseBuilder.Any() || (ownUnits.Count < Info.SquadSize)) if (!allEnemyBaseBuilder.Any() || (ownUnits.Count < Info.SquadSize))
return; return;