From 04033e5c79b457b672db51ced1c5ede4959f23e0 Mon Sep 17 00:00:00 2001 From: abcdefg30 Date: Sat, 27 May 2017 11:37:43 +0200 Subject: [PATCH] Don't iterate over an array with only one element --- make.ps1 | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/make.ps1 b/make.ps1 index d783ed9444..88c0d75fff 100644 --- a/make.ps1 +++ b/make.ps1 @@ -195,21 +195,19 @@ function Docs-Command function FindMSBuild { - $msBuildVersions = @("4.0") - foreach ($msBuildVersion in $msBuildVersions) + $key = "HKLM:\SOFTWARE\Microsoft\MSBuild\ToolsVersions\4.0" + $property = Get-ItemProperty $key -ErrorAction SilentlyContinue + if ($property -eq $null -or $property.MSBuildToolsPath -eq $null) { - $key = "HKLM:\SOFTWARE\Microsoft\MSBuild\ToolsVersions\{0}" -f $msBuildVersion - $property = Get-ItemProperty $key -ErrorAction SilentlyContinue - if ($property -eq $null -or $property.MSBuildToolsPath -eq $null) - { - continue - } - $path = Join-Path $property.MSBuildToolsPath -ChildPath "MSBuild.exe" - if (Test-Path $path) - { - return $path - } + return $null } + + $path = Join-Path $property.MSBuildToolsPath -ChildPath "MSBuild.exe" + if (Test-Path $path) + { + return $path + } + return $null }