epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix an integer overflow in Target.IsInRange.

Browse Source
This commit is contained in:
Paul Chote
2013-07-11 18:43:55 +12:00
parent a49cc78c57
commit 045eb12388
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
OpenRA.Game/Traits/Target.cs
View File

@@ -90,8 +90,13 @@ namespace OpenRA.Traits
return false; return false;
// Target ranges are calculated in 2D, so ignore height differences // Target ranges are calculated in 2D, so ignore height differences
return Positions.Any(t => (t.X - origin.X)*(t.X - origin.X) + var rangeSquared = range.Range*range.Range;
(t.Y - origin.Y)*(t.Y - origin.Y) <= range.Range*range.Range); return Positions.Any(t =>
{
var dx = (long)(t.X - origin.X);
var dy = (long)(t.Y - origin.Y);
return dx*dx + dy*dy <= rangeSquared;
});
} }
} }