Reset stream position after TryParseSound failures
This commit is contained in:
@@ -170,6 +170,7 @@ namespace OpenRA.FileFormats
|
||||
out int sampleRate)
|
||||
{
|
||||
channels = sampleBits = sampleRate = 0;
|
||||
var position = stream.Position;
|
||||
|
||||
try
|
||||
{
|
||||
@@ -187,6 +188,10 @@ namespace OpenRA.FileFormats
|
||||
rawData = null;
|
||||
return false;
|
||||
}
|
||||
finally
|
||||
{
|
||||
stream.Position = position;
|
||||
}
|
||||
|
||||
channels = 1;
|
||||
sampleBits = 16;
|
||||
|
||||
@@ -19,6 +19,8 @@ namespace OpenRA.FileFormats
|
||||
{
|
||||
bool ISoundLoader.TryParseSound(Stream stream, string fileName, out byte[] rawData, out int channels, out int sampleBits, out int sampleRate)
|
||||
{
|
||||
var position = stream.Position;
|
||||
|
||||
try
|
||||
{
|
||||
var vocStream = new VocStream(stream);
|
||||
@@ -33,6 +35,10 @@ namespace OpenRA.FileFormats
|
||||
channels = sampleBits = sampleRate = 0;
|
||||
return false;
|
||||
}
|
||||
finally
|
||||
{
|
||||
stream.Position = position;
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
@@ -181,6 +181,7 @@ namespace OpenRA.FileFormats
|
||||
{
|
||||
rawData = null;
|
||||
channels = sampleBits = sampleRate = 0;
|
||||
var position = stream.Position;
|
||||
|
||||
try
|
||||
{
|
||||
@@ -197,6 +198,10 @@ namespace OpenRA.FileFormats
|
||||
Log.Write("sound", e.ToString());
|
||||
return false;
|
||||
}
|
||||
finally
|
||||
{
|
||||
stream.Position = position;
|
||||
}
|
||||
|
||||
rawData = RawOutput;
|
||||
channels = Channels;
|
||||
|
||||
@@ -63,11 +63,8 @@ namespace OpenRA
|
||||
int sampleBits;
|
||||
int sampleRate;
|
||||
foreach (var loader in Game.ModData.SoundLoaders)
|
||||
{
|
||||
stream.Position = 0;
|
||||
if (loader.TryParseSound(stream, filename, out rawData, out channels, out sampleBits, out sampleRate))
|
||||
return soundEngine.AddSoundSourceFromMemory(rawData, channels, sampleBits, sampleRate);
|
||||
}
|
||||
|
||||
throw new InvalidDataException(filename + " is not a valid sound file!");
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user