Merge pull request #8558 from GraionDilach/grantupgrade-warhead-checkvalidity

Add target validation to GrantUpgrade warheads.
This commit is contained in:
Pavel Penev
2015-07-02 23:34:28 +03:00
2 changed files with 8 additions and 6 deletions

View File

@@ -29,6 +29,10 @@ namespace OpenRA.Mods.Common.Warheads
public readonly WRange Range = WRange.FromCells(1);
// TODO: This can be removed after the legacy and redundant 0% = not targetable
// assumption has been removed from the yaml definitions
public override bool CanTargetActor(ActorInfo victim, Actor firedBy) { return true; }
public override void DoImpact(Target target, Actor firedBy, IEnumerable<int> damageModifiers)
{
var actors = target.Type == TargetType.Actor ? new[] { target.Actor } :
@@ -36,6 +40,9 @@ namespace OpenRA.Mods.Common.Warheads
foreach (var a in actors)
{
if (!IsValidAgainst(a, firedBy))
continue;
var um = a.TraitOrDefault<UpgradeManager>();
if (um == null)
continue;