From 15c2800601f20bd5a29d266646836e7c41bd2ebc Mon Sep 17 00:00:00 2001 From: abcdefg30 Date: Fri, 7 Jan 2022 02:21:06 +0100 Subject: [PATCH] Retire the release-20191117 UpdatePath --- .../Rules/20191117/ReplaceAttackTypeStrafe.cs | 44 ------------------- OpenRA.Mods.Common/UpdateRules/UpdatePath.cs | 5 --- 2 files changed, 49 deletions(-) delete mode 100644 OpenRA.Mods.Common/UpdateRules/Rules/20191117/ReplaceAttackTypeStrafe.cs diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20191117/ReplaceAttackTypeStrafe.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20191117/ReplaceAttackTypeStrafe.cs deleted file mode 100644 index 868854e919..0000000000 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20191117/ReplaceAttackTypeStrafe.cs +++ /dev/null @@ -1,44 +0,0 @@ -#region Copyright & License Information -/* - * Copyright 2007-2021 The OpenRA Developers (see AUTHORS) - * This file is part of OpenRA, which is free software. It is made - * available to you under the terms of the GNU General Public License - * as published by the Free Software Foundation, either version 3 of - * the License, or (at your option) any later version. For more - * information, see COPYING. - */ -#endregion - -using System.Collections.Generic; -using OpenRA.Mods.Common.Traits; - -namespace OpenRA.Mods.Common.UpdateRules.Rules -{ - public class ReplaceAttackTypeStrafe : UpdateRule - { - public override string Name => "Replaced AttackAircraft AttackType: Strafe logic."; - - public override string Description => - "The AttackType: Strafe behaviour on AttackAircraft has been renamed to Default,\n" - + "and AttackTurnDelay has been removed. A new AttackType: Strafe has been added, with a\n" - + "new StrafeRunLength parameter, designed for use with the FirstBurstTargetOffset and\n" - + "FollowingBurstTargetOffset weapon parameters."; - - public override IEnumerable UpdateActorNode(ModData modData, MiniYamlNode actorNode) - { - var aircraft = actorNode.LastChildMatching("Aircraft"); - if (aircraft != null) - { - var attackAircraft = actorNode.LastChildMatching("AttackAircraft"); - if (attackAircraft == null) - yield break; - - var attackType = attackAircraft.LastChildMatching("AttackType"); - if (attackType != null && attackType.NodeValue() == AirAttackType.Strafe) - attackAircraft.RemoveNode(attackType); - - attackAircraft.RemoveNodes("AttackTurnDelay"); - } - } - } -} diff --git a/OpenRA.Mods.Common/UpdateRules/UpdatePath.cs b/OpenRA.Mods.Common/UpdateRules/UpdatePath.cs index 644639b582..64ec407315 100644 --- a/OpenRA.Mods.Common/UpdateRules/UpdatePath.cs +++ b/OpenRA.Mods.Common/UpdateRules/UpdatePath.cs @@ -34,11 +34,6 @@ namespace OpenRA.Mods.Common.UpdateRules Justification = "Extracting update lists to temporary variables obfuscates the definitions.")] static readonly UpdatePath[] Paths = { - new UpdatePath("release-20191117", "release-20200202", new UpdateRule[] - { - new ReplaceAttackTypeStrafe() - }), - new UpdatePath("release-20200202", "release-20200503", new UpdateRule[] { new RemoveYesNo(),