epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix overflow when calculating array quantile index

Browse Source 
Fixes a crash which happens when trying to generate very large maps,
such as 256x256.

```
Exception of type `System.IndexOutOfRangeException`: Index was outside the bounds of the array.
   at OpenRA.Mods.Common.MapGenerator.MatrixUtils.CalibrateQuantileInPlace(Matrix`1 matrix, Int32 target, Int32 count, Int32 outOf) in /home/ashley/devel/OpenRA/OpenRA.Mods.Common/MapGenerator/MatrixUtils.cs:line 719
   at OpenRA.Mods.Common.Traits.RaMapGenerator.Generate(Map map, MiniYaml settings) in /home/ashley/devel/OpenRA/OpenRA.Mods.Common/Traits/World/RaMapGenerator.cs:line 755
...
```
This commit is contained in:
Ashley Newson
2025-01-28 19:31:14 +00:00
committed by Gustas Kažukauskas
parent ddfdfcfee3
commit 19585ec7ac
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
OpenRA.Mods.Common/MapGenerator/MatrixUtils.cs
View File

@@ -718,7 +718,7 @@ namespace OpenRA.Mods.Common.MapGenerator
{
var sorted = (int[])matrix.Data.Clone();
Array.Sort(sorted);
var adjustment = target - sorted[(sorted.Length - 1) * count / outOf];
var adjustment = target - sorted[(long)(sorted.Length - 1) * count / outOf];
for (var i = 0; i < matrix.Data.Length; i++)
matrix[i] += adjustment;
}