fixed #995 - remove duplication in next/prev song in MusicPlayerLogic.cs

OpenRA.Mods.RA/Widgets/Logic/MusicPlayerLogic.cs

@@ -8,6 +8,7 @@
  */
 #endregion
 
+using System.Collections.Generic;
 using System.Drawing;
 using System.Linq;
 using OpenRA.FileFormats;
@@ -109,11 +110,8 @@ namespace OpenRA.Mods.RA.Widgets.Logic
 			}
 		}
 
-		string GetNextSong()
+		string ChooseSong( IEnumerable<string> songs )
 		{
-			var songs = Rules.Music.Where(a => a.Value.Exists)
-				.Select(a => a.Key);
-			
 			if (!songs.Any())
 				return null;
 
@@ -122,22 +120,16 @@ namespace OpenRA.Mods.RA.Widgets.Logic
 
 			return songs.SkipWhile(m => m != CurrentSong)
 				.Skip(1).FirstOrDefault() ?? songs.FirstOrDefault();
+		}
 
+		string GetNextSong()
+		{
+			return ChooseSong( Rules.Music.Where( a => a.Value.Exists ).Select( a => a.Key ) );
 		}
 
 		string GetPrevSong()
 		{
-			var songs = Rules.Music.Where(a => a.Value.Exists)
+			return ChooseSong( Rules.Music.Where( a => a.Value.Exists ).Select( a => a.Key ).Reverse() );
-				.Select(a => a.Key).Reverse();
-			
-			if (!songs.Any())
-				return null;
-			
-			if (Game.Settings.Sound.Shuffle)
-				return songs.Random(Game.CosmeticRandom);
-			
-			return songs.SkipWhile(m => m != CurrentSong)
-				.Skip(1).FirstOrDefault() ?? songs.FirstOrDefault();
 		}
 	}
 }