From ba1fa7cd8179b3ed0c9e36fa2e4f81a365c50367 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= <matthias@mailaender.name>
Date: Sat, 28 Jun 2014 09:50:50 +0200
Subject: [PATCH 1/8] new check for undefined actors

---
 OpenRA.Mods.RA/Lint/CheckActors.cs   | 28 ++++++++++++++++++++++++++++
 OpenRA.Mods.RA/OpenRA.Mods.RA.csproj |  1 +
 2 files changed, 29 insertions(+)
 create mode 100644 OpenRA.Mods.RA/Lint/CheckActors.cs

diff --git a/OpenRA.Mods.RA/Lint/CheckActors.cs b/OpenRA.Mods.RA/Lint/CheckActors.cs
new file mode 100644
index 0000000000..c6c259f3d0
--- /dev/null
+++ b/OpenRA.Mods.RA/Lint/CheckActors.cs
@@ -0,0 +1,28 @@
+#region Copyright & License Information
+/*
+ * Copyright 2007-2014 The OpenRA Developers (see AUTHORS)
+ * This file is part of OpenRA, which is free software. It is made
+ * available to you under the terms of the GNU General Public License
+ * as published by the Free Software Foundation. For more information,
+ * see COPYING.
+ */
+#endregion
+
+using System;
+using System.Linq;
+using OpenRA.Traits;
+
+namespace OpenRA.Mods.RA
+{
+	public class CheckActors : ILintPass
+	{
+		public void Run(Action<string> emitError, Action<string> emitWarning, Map map)
+		{
+			var actorTypes = map.Actors.Value.Values.Select(a => a.Type);
+			foreach (var actor in actorTypes)
+				if (!map.Rules.Actors.Keys.Contains(actor.ToLowerInvariant()))
+					emitError("Actor {0} is not defined by any rule.".F(actor));
+		}
+	}
+}
+
diff --git a/OpenRA.Mods.RA/OpenRA.Mods.RA.csproj b/OpenRA.Mods.RA/OpenRA.Mods.RA.csproj
index aeb4fdda34..88a75a8b9c 100644
--- a/OpenRA.Mods.RA/OpenRA.Mods.RA.csproj
+++ b/OpenRA.Mods.RA/OpenRA.Mods.RA.csproj
@@ -518,6 +518,7 @@
     <Compile Include="Activities\MoveWithinRange.cs" />
     <Compile Include="Lint\CheckPlayers.cs" />
     <Compile Include="Player\ProvidesCustomPrerequisite.cs" />
+    <Compile Include="Lint\CheckActors.cs" />
   </ItemGroup>
   <ItemGroup>
     <ProjectReference Include="..\OpenRA.Game\OpenRA.Game.csproj">

From a6ad3599140b3556be1fd482b3160f3c79243141 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= <matthias@mailaender.name>
Date: Sat, 28 Jun 2014 09:51:12 +0200
Subject: [PATCH 2/8] remove legacy actors as a test case

---
 mods/ra/maps/desert-shellmap/map.yaml | 18 +++----
 mods/ra/rules/structures.yaml         | 74 ---------------------------
 2 files changed, 9 insertions(+), 83 deletions(-)

diff --git a/mods/ra/maps/desert-shellmap/map.yaml b/mods/ra/maps/desert-shellmap/map.yaml
index cb74e78344..0b052318c9 100644
--- a/mods/ra/maps/desert-shellmap/map.yaml
+++ b/mods/ra/maps/desert-shellmap/map.yaml
@@ -439,7 +439,7 @@ Actors:
 	Actor167: powr
 		Location: 54,74
 		Owner: Allies
-	Actor39: pbox.e1
+	Actor39: pbox
 		Location: 70,89
 		Owner: Allies
 	AlliedTechnologyCenter: miss
@@ -452,10 +452,10 @@ Actors:
 	Actor150: apwr
 		Location: 94,90
 		Owner: Allies
-	Actor35: pbox.e1
+	Actor35: pbox
 		Location: 68,85
 		Owner: Allies
-	Actor178: pbox.e1
+	Actor178: pbox
 		Location: 77,76
 		Owner: Allies
 	Actor300: brik
@@ -495,7 +495,7 @@ Actors:
 	AlliedWarFactory1: weap
 		Location: 75,81
 		Owner: Allies
-	Actor156: pbox.e1
+	Actor156: pbox
 		Location: 52,71
 		Owner: Allies
 	Actor343: brik
@@ -628,10 +628,10 @@ Actors:
 		Location: 82,69
 		Owner: Allies
 		Facing: 0
-	Actor30: pbox.e1
+	Actor30: pbox
 		Location: 47,77
 		Owner: Allies
-	Actor29: pbox.e1
+	Actor29: pbox
 		Location: 42,75
 		Owner: Allies
 	Actor217: sbag
@@ -1001,7 +1001,7 @@ Actors:
 	Actor212: brik
 		Location: 61,80
 		Owner: Allies
-	Actor361: pbox.e1
+	Actor361: pbox
 		Location: 71,96
 		Owner: Allies
 	Actor365: hpad
@@ -1016,7 +1016,7 @@ Actors:
 	Actor193: fix
 		Location: 69,70
 		Owner: Allies
-	Actor42: pbox.e1
+	Actor42: pbox
 		Location: 67,70
 		Owner: Allies
 	Actor262: fenc
@@ -1217,7 +1217,7 @@ Actors:
 	LstUnload: waypoint
 		Location: 60,93
 		Owner: Neutral
-	Actor184: pbox.e1
+	Actor184: pbox
 		Location: 96,79
 		Owner: Allies
 	Paradrop1: waypoint
diff --git a/mods/ra/rules/structures.yaml b/mods/ra/rules/structures.yaml
index 49f1c47e6c..f9d3db2917 100644
--- a/mods/ra/rules/structures.yaml
+++ b/mods/ra/rules/structures.yaml
@@ -459,43 +459,6 @@ PBOX:
 		FallbackRange: 6c0
 	AutoTarget:
 
-# Legacy definitions to keep compatibility with outdated maps
-PBOX.E1:
-	Inherits: PBOX
-	-Buildable:
-	RenderBuilding:
-		Image: PBOX
-
-PBOX.E3:
-	Inherits: PBOX
-	-Buildable:
-	RenderBuilding:
-		Image: PBOX
-
-PBOX.E4:
-	Inherits: PBOX
-	-Buildable:
-	RenderBuilding:
-		Image: PBOX
-
-PBOX.E7:
-	Inherits: PBOX
-	-Buildable:
-	RenderBuilding:
-		Image: PBOX
-
-PBOX.SHOK:
-	Inherits: PBOX
-	-Buildable:
-	RenderBuilding:
-		Image: PBOX
-
-PBOX.SNIPER:
-	Inherits: PBOX
-	-Buildable:
-	RenderBuilding:
-		Image: PBOX
-
 HBOX:
 	Inherits: ^Building
 	Tooltip:
@@ -545,43 +508,6 @@ HBOX:
 		PortYaws: 0, 176, 341, 512, 682, 853
 		PortCones: 86, 86, 86, 86, 86, 86
 
-# Legacy definitions to keep compatibility with outdated maps
-HBOX.E1:
-	Inherits: HBOX
-	-Buildable:
-	RenderBuilding:
-		Image: HBOX
-
-HBOX.E3:
-	Inherits: HBOX
-	-Buildable:
-	RenderBuilding:
-		Image: HBOX
-
-HBOX.E4:
-	Inherits: HBOX
-	-Buildable:
-	RenderBuilding:
-		Image: HBOX
-
-HBOX.E7:
-	Inherits: HBOX
-	-Buildable:
-	RenderBuilding:
-		Image: HBOX
-
-HBOX.SHOK:
-	Inherits: HBOX
-	-Buildable:
-	RenderBuilding:
-		Image: HBOX
-
-HBOX.SNIPER:
-	Inherits: HBOX
-	-Buildable:
-	RenderBuilding:
-		Image: HBOX
-
 GUN:
 	Inherits: ^Building
 	Buildable:

From 59c12c2a319ddcfa512db5750a600377e50fc35a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= <matthias@mailaender.name>
Date: Sat, 28 Jun 2014 09:51:50 +0200
Subject: [PATCH 3/8] now that we check actors and players we can't exclude
 them

---
 OpenRA.Lint/YamlChecker.cs | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/OpenRA.Lint/YamlChecker.cs b/OpenRA.Lint/YamlChecker.cs
index bfebb0d566..ba7b1944aa 100644
--- a/OpenRA.Lint/YamlChecker.cs
+++ b/OpenRA.Lint/YamlChecker.cs
@@ -68,14 +68,6 @@ namespace OpenRA.Lint
 
 				foreach (var testMap in maps)
 				{
-					if (testMap.RuleDefinitions.Count < 1)
-					{
-						if (verbose)
-							Console.WriteLine("No custom rules detected. Omitting Map: {0}".F(testMap.Title));
-
-						continue;
-					}
-
 					if (verbose)
 						Console.WriteLine("Map: {0}".F(testMap.Title));
 					testMap.PreloadRules();

From f9d5a439d8719e167b3b3eafcfc247a5518c39e9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= <matthias@mailaender.name>
Date: Sat, 28 Jun 2014 09:52:00 +0200
Subject: [PATCH 4/8] and another hit for invalid players

---
 mods/cnc/maps/necessary_illusions.oramap | Bin 5061 -> 5328 bytes
 1 file changed, 0 insertions(+), 0 deletions(-)

diff --git a/mods/cnc/maps/necessary_illusions.oramap b/mods/cnc/maps/necessary_illusions.oramap
index ca462a0e476f5811e3b6a5869190f2d579ad4121..be5d71ceb9c7b5504f53468a1942eaea971657e7 100644
GIT binary patch
literal 5328
zcmZ{o2T)T@yT>7+x6lPCp$bYbf}tx-K@8GE4IPvYp-PY<MZkgz(hP_c>AeYr-kY>Y
z?-D_J4-qc-&iBoo`_4UQ=j`l0&;P$WXU^`P`RQr{i5Lk82*?N!3W;jpzBQ6TXbA{j
zG!qbz60j4vT6>7vIJ+4dkP`rlFAVi#y^Hk`{*(lSL|7mJ0g>IMaMOG`VXT_jqI~vP
zoVN9kj9o3C3V`v#V~~`HbC8lKkIGQ$wt9NA*)8y!<VE6hxI^Ch(C@6q)y>3N-<p}k
z=})Rc={>JZMf%DoMw)uo(I=oA!zib)bE5g+>GG5esTO#c)O<Dj!{K!JotDlTktl|P
z8!S2=N7IS9EQF=89!WXTrTYTGK7HGBT+hO{*r;BG+D3GZWn3iOsGzPr8UlUO{TA)(
z{E|#QWJDkkco=zpGza&mLd0QN8k2OzoL^2oe|mv0jfG!Jw@3lE4x$czHDr=_rrHv9
zVcGS8pdSjrw9J&my*APa@bI7L9p0)3i`}gqSWpC2{AyVM$vV||<y)|lO0dcSVdLv)
zCB0M@P4uWHf9*-Qhjm7og3Qo}fC($eg%EvNcY~e-<iOa`i~Ap7?66uE{N39hN&^y=
z7JL2Sl<UU02+C7JVW28Je2x1>Rxli#9-N;U_$f;3hXQGunTYZXzzwnkqy;F#iQY=x
zkyE>PllTVg@+n-d#uQmgjOdF8S5h5tm&a$R`p`(+`NF?KS}{NBh`?v8>cB^@f>h$+
zC8|VGSWX-N``X<g2XyYx`pMnCRNYkj6KiIxC^FD@`AZpfMLDNY7pR7ACWm;T7gTW~
zM?gc%F-*S~34?)zmZGM0Yv|^3h)X|$oAKhYCBQtO4~_Vpoi32_@a1S+vDRh5)(51F
z3mXKpKq?S^w+(avqf<7y>d!nSB*u$pKEQIoeV$izm7T*6);l)=0x;(Acfk^Uppxgt
zV;@%ljrE@2;AJi%B*tevi=-0*S;o30d7d+!BL!!L(CQX<acC28=I#mQ4yB@w@kRI|
zDVw}}GffrW<VZn*jghchLJ1I~Ufd1*S-cJKqnjb!;;jWDNWY8m{{cmUU4H*o*^K5W
z164soG{+@`m}Pq~nZ>aU<|s3tWuNU!&AnN5fAG3etGvN4CsO;<md-(%Fpd=J+47p#
zaMZa`mDnI~jV>+MUgJ>qIomj%<*&{Q!-)rdY#F2(h;(D!<ekYa$+tOD7z>E?_W45{
zA?t)6l>sDnE?tvRW|{A^YPO1-4^DY`w<CDQlxj2(Mn8J=H+pGcrE3e18)RvdC_-tS
z)e1+tGz!PWOSj1`qxugaP5}?~zjN41cS63+%_;{F);?dL56f-V#~D@+@Gj7W1xb^W
zx5@rQ2`6-sbz<WmoFG9zRBNN$ZeFYq=TVZ0aX+Itd~eH>Eb}^ple<Cl9lW-<=cI!@
zAnu&SvGWd^v?|I8YQruPEng_w1ksT0gvZ5W$d0h1lkZr%Zn+Yvaww0gnyce&jAYz;
zFuEmQB^mjp(2dxaO1oz){=!d2hIExN{U8@TbsMve!$dR5&i8`JrzQ**-vy9hRmD&F
z532TosRkTnMR`h_iE$G4H<KYI@33)D{2Y-RZp)iSnLRUzh@E?^RUiW8L_%L<*SRIG
z<v=sRC%4Rimd*T6jvo;s;yxvcHu&B)<&HWYB$HDe>T3EJVlp~0MG{7h^9|^y=!vM4
z>83Oty1my%htni`HT=C*z(*<bf_PnfidlS5X3RJA!W#GlxTsM^vqS42y+F8=@k4-%
z@11*iL&l-`xAUEp$QlCuX|n3?v!Xld3WT4yYRSy|E9f}yDXN_itP=*O&ZBERau1hG
zcu&<u%-^=gy1b$kuZs6b9e%qV>kl|2T2#-Ajkc4?agC!8VOB$4EVb$^(ZtxgGU1zt
zFy#6PO420*>ZbG@Qfy&>eA!#lX0%(L4;WDK8>q{dh<`@u`QGjU?3Ze+r=x?aZYdv<
zUx^K)9EFQ-%8v!ljq=`rNaV}`-02#09Iw)fS<*U!Zo;~))p2b>2mSG8ont#9tu>yB
z1{C_AE#$4m!;ke&s=708fj$<kU-yWALUFpNsA!|elxhEv$wsSkgENSGFvm|7g+mLI
zfPzyllSF_57vaMT3J+N~O&e(Ev;9=vap)=*g@c>8x_9UB?+bv3n<lO!->j<}Pb{>T
zF+P3O)z{=ZuxpejEq5G5t_z3WeJb1U%!|Z~)XL1hEV4*pC<YjllSR^+?`OH3BFaGA
zvvmwIAw<Y8H+$W^L+d3QKXf+vD|wQ)FfCAo^)=hSExBi*?xW+w)P>JelQGS%QyX!$
zTtoUV02q&}SKKG}zlw4<01(8B_IZ6gR@vVl)u{{Cq=k%_^ZfG7*-t!SvapZ!N;-gw
za_823Up)@|#XWxG&v*l}9VrmN@FNY=wBFP}ERM=uADzZlo?DGcP7k5?f4}eneLebB
z^7Bk0?$4vW8)H8kjtnK5)a~3(W?pIjn0AU$vWiaI`o~J?1?mCwYNj6kGrkGslC_FF
zyJuGr<-)d6KyS;in(2e*=@F_WomuXu*gqD)2_HQc7C`4kl~f83Hjd!mtT4@l*LNi|
z{oIBg#5h1Q=^z0nd))weum&e=X-#@iQ5nC(a5$g58UfjJCjcs=2lgr0KPU(X*kz`J
zY!xM!yToyJ@%T4$edVs7Mim&nI`*f0A`f`kqLpA-=YP8o(wj^wF(oRAB3aCTTDpHV
z3Ky5~PQcXvw(lMt*ohU$UN)->PXaFIBaLhQMPK%4*I>-%>6fCDd&v7<*Mk>5V@z`W
zZy617>&F?q)^@Oi#2BSGj(oeQ)Cn}s7eY!Xi`GR53w+mVmmL_X@(Y3ZI3u5KYau$s
zR(7fRn7;6~O8Qso@#`Oo?&|QS&RWq}=mq~3a=&&L{K{oPm)Mg2MayBsVkuSKH?&G<
zyc=W{TJoNVJ~!+Kggd*`f&F8`tz_2<wP)VN77HkF)4kwqzBhN6+6T!`sh)k>1@`xL
zW;<Uc!LC<SlxchNj^*1vl-OfxG1daa=->UF_GU;I<$W|$=whC-)a)`RP{*$P(doDR
z0>=RTIGTAr1L0QI8JuQ(PhX~+k@v>+Gn#dd0X;zocSP1fT}Sl~%G<lDJm@S~?}XVJ
z^R$iFSUX4~(Y)3r*vqYq*rYfK94B1oF^LPoW()QNJ&qJJTY%=pfa6?NTeH_M$_CxF
zYC|Np`X4<3gn9o4yt|w3N%@pP_5C`@NlWjGzNKy@H0;*7)4zguj|N<V5BF1z@?ERr
z{rk%g>EoV02iwi}PZ%qsowKJLrdeK3ZYFQIb+*)!T%P3HdnYY@r#id3_8a^>sG@7$
zg*X3jM}ZsC<{3eT`ExJ39j7ZG)wLHz&hH1<l%49HgB8-|D+O&#-Paz8VJ;HYChcSt
zcES_APq`m+TGpRZd)deGECpKCjdnV}^R*6GApLgkx8V1fQ_b6iBwQn@`-ETEs-CnV
z*TRJJ#JYM;5M+4Lf~99gt4$?sX@Y6585ttqq%9gWW*hif7CS+$ESawv@n3b-&UL=X
zHmGSA?M|YeiI7QJA>B}$tDMuzXFFyRPNbe0sf49~D}@F2TrO0X685sDwaH2}rnz-e
zzsh(lM3FZZOngb1J|~^#UnT6LZ#5${wwo7|SoFhYJ_qkTn)%{kSNBB$4s$6m+|k%W
z#(d$NJYIY#k>Iy<;{|Wul_nuxSIn3tdzE!ZctUR}@XLG+gw*Qii^d+->;tpA3Jb>N
zAJz{=t`f#7z9!P|tL`-kGhRMh=T_qMa7A34J3^CM1;avo^zZYbbGcD~%Z2q<&VN?K
zWhpMClz8Kiy8F!EqBJqB<Nh3lWT*Y;&()>iI$dV4_B&i8r7{cbGvx7}(HjXQ%X05L
znOd1SJ=(@imKA;Zn^>_&?h&>Vu^EfbJkMb@;jBokn{7~(M1dvu$j8V(Gng81mfmb1
zXAWxT&=(+k<YbsebJiLgvX}Zk^_Zzr)eR^!%~eB~>iTB-`G8EfYqJB}iVVDh+Ka7p
zlBACMhfDYjiA(j}|D+A{nIs`j(KnxbiKNIcslPRHv6<7vmah`R@b%GZfe!+zcw4tO
zpYjx3@2eSt5jjUVJOutJpsB(HYa|!Mow%d-{LiHIW-kN{3rY$vZq*0kdSCn*c6YMm
zowY?FlX2C#Pa|<)@bWmcCr-|Ae%v_2J?PbPc9jY=-2t-pbpt8)L>E!HtIv+DlJ%xm
z$FTegnZ-TE&5___KNw?Mg%AgYD}|30w<{w#)*`y(?w8~nCgBClh7-32+x9J!5U|VH
zCu-A5D~3t(4+j~D7fwW_4lWiDH9kRO<TRI|_g{1SxUtC;XqFbscm;PBqU2s1Zy<mZ
z$)iX2o2Ohf=ONSl{F?H7ea)^^g+NfwhP4v?f&Y)6!%+8+U)MHvKajdz7rA(KFyHL7
z>2~>Hql)P^5OK4Rr?6w~YLgIOHC%7z%lK&eW$H;$Y&l{jg4>dMBAwX#ww@wSxn3L0
z1^aZQvGmW1oBFPIj1S80EoAnFbIaC7JmOguSr32Z4tEKW>!zGpPw$WXS4A9KaT8hI
zAsn4f29YRpktd_*AoQT|_PD!habJC5U;T;DZ>Zk*pQwVHg`-pfVy-6M2%#0|ggi{m
za?BJ5a!NY*G5`Ee<736d&`*@5=&8q~p4hj3=0`+98&bdIhnG39xm|Rx)Qc=cERM24
z8zxjP+f*i_o1)j<X+=jqZirF1a3A*9n;3+3?s95oL>@{(KLk-5txGHltqZUS$0%7w
zA)}VP#&7MLeb1^A-6;QCMmp)oY;wm8?@v3cgyebja4pCCm5Jmted2{;G78z06$gaQ
zm(qUUBr{@DH*eA%q<0jf?zvDbv6ts*3EWIjc4+^EgLps8qE53VM=-x+eLGOst-t;1
z+N(b5^#jz~u6A2@!ZW|IUpuH|CoWA3=!+=5WXUlpbBQGQ?H7{t5X)%@$9^B#E2?E_
zMS9HV$reiFq5c!%jc?4oO-_MS_7qY9LcTX^S{1xsI(*#Ugihn-PHs={QJFk7pXqJE
zG^MmcpyaXFoXwxz$Q<&l1RO1YG>kgLn;KtpWbg1A7VBkR!BV2K1gA0&?)*Aa>3~U{
z^BM<aciSxNU$^jfJUwGXDYB+eT{{n1v$%hp&kU37W9-F@DEh4(7fwguF}t{D$e6(*
z>GsFcmQ7Lu18=2R<a49+Pv7fA?GKv<U2p%%g=FTIf@-fNc}u@5OEx#w@OsK?;M)%4
z9+bv@V%8p8F)E;k6}buq2&_z*M+>BIs@CagT*&J{KL74fIZy7WX8M`H4eNHb-|$)N
z_f%q=VcxJtE;h=qFboLgDv$JPT{v`4(55?gJL#u&EDK%#>;P5SQ8LeXF!bx|wGEBQ
z@3*Sm8vGefrMm?S=GRl+PR3{--tM((bm2Y3`>*xG*v_bQp3y`$7T6z_-x)&4;Brhb
z`_0z_H2_&jj!&AECKArXQ47fsv(~4fxIND>C3ry~AHG;@V%ZV1m<NkJ?7mv3{}f2@
zYKZQC$%Ejd8MQnOLa^;6Q)mNSv50@jLx8ob%U|>mbcr2;|BW7sjCH(I#c36d(P7{W
zAP&&-)p=^rC&yFHHzkd!kgva6<*ifdIZo@1w8TVyQd*q2`}|f@4gK%R@A3LI8kouP
zJI)cJV>@+VQ13V_blB+P<J9BnSfrJs4u;ETynbg#Lw3sawvvNYT(ZlwA9LpGDH&V&
zJLr5V+~`Q*rsQ!(1#+0<p5wb9Y?s`b1Na!{NM>I-{>iDPt|2+uZxakorG1&LhE-KY
z1erOqdz&+v{3Hvm!S!!(R!WfG9-DNuFC02u_uMJnZ#t83-k_~d(=WY!Z$2(?EDIf2
zWA1vG&WXTakJ%LK9<yEyeT$dtXBv>j<Mxal-ErT4qXL&u*l+vi9tCOZGw4*aasMBG
zniQ##60De?Vr5BHR*|Guh%-pH5#sE8AqgcH>{L~9`fMz)RK>3R<-<8)NelHHcjn|G
zo{F02hMABUJbosGIEcLQet43Ss4}Cnee~dU%+OY{nBZ3_`HvGXil1$=Rk2vW?=fSr
zyC32m$Vh2Fhtcx9%;U>p3}b}8F_TI<4g1Xgj{e>Ul_%m*;%uYm<FtZRdN=fVn?AR}
zNe>I;0T255qGMw9Kae9>;%#~<q-gd^1#@U?3D`7=$4Iz6$#XOzM9T`q;qOJfOY>@>
zun&SS+nvKW;Gg{4Znm+@gvX_3(v!;$*J`ER_^lJ`Kc7#eagXA`E6UO@?CSsqxEC$m
zTXG&|$32p@g>Ffb`oV1<s)$erCVPO!EvGTaOf0((5fu;Qz13ZbC=SY3q5>b=<h2#r
zypXY>y`Md4`}Dcsat$IX#=3cHM4hE4M_P^i&5Q8eihh(9fB$mS@a@wlMC6I$+Rwlg
z9nHdC4s>0@RN5xPPc%wxDGg#8YGu=SI|3Q`?ogx=sUTYko(wfwn_F@Md)4UD2Gn;B
zVF@Zbtam4(j6S>2C43gJZ(~$1tdLfJ+&R|gNxtQ*fK4x{ykA`{=UTKtPC_?kncc1*
zOwVU?zyswDn_2nz8GcjcjeJrUWR;xsWrhrlBbhHVoi>;Ac-k32+ip481EdcYffDjm
z#Zs`cQY6@r>Aka!6j$d`C1lT6z~#jFMmdL+v~^*9CHJ=nLkyyZl01TEFD8B-#<LYg
zu1+7;yC<2Y&Q<wswlYi@XRQ|oSe_H>Y7+uDf&U*MWVz&j|6E@}uj>EeLgIgL;r~H}
w|J&@}YyKZI!b_Vkp@EkS^2+R=9pKXKY6tk28!^e%pn%Ie^|A(E&641M0M5TBQvd(}

literal 5061
zcmZ`-WmFW<x*b4DV(6BkM9HB`U<9ONC>c_zp}Rwd7Lb$}N)QAo89=&AIs{Z&hLV!*
z8t~$~_pSThUGJUqt#x95`>gY0?;qc%t&Ve#3IG5Q0KBD<&stjA2oit*Kx8KXfPZ)E
zY~jXlY45UYHt#auNMlCza2WZ>zF2dAdds;e-9GmAizH}#eYv%;m@5mLFsv){%vk^=
zpnCP~RxTO)Rs-asYf@xAi{w?SXDkg<9~V*7F^#=0i~h3=p_9+KC0k%cNX^3qp9ws3
zjjpRPJA1uJOiuC{Q9tYv?G}AYw(-@+KY|<(m=q|Y7?A_n(&r1Fd;L?%ma&a;>E2NU
zgI9x{P_PDKCVVEmLs{?H%w>vJFr#I*>=)-}kH{V!K*?O>oF=GlGB8#6uD~wlQJ}>J
zR4UxrfviC?)HiG?f<dBlouNueRDB5eo&}PBOn)R?r@B1Qt@sD0@O2+%#x&fpAPfF0
z3QG2VDOmo3{?^uka&@!A>&-n{5CJV7!?D#dQ_c%3X*b|Sj+QGY1b|H-J288sk!HkX
z)VLXxm!&o%tz7IBhrcI>(JFp72posAU{9S&7rJ=?m{=t87|N!PwF$E~LXSs}zBn)W
zU?Bh;WY|G&lHmpHUWs;uO<n8$(f@@-&-Y%)rG@f0I<0OJbdd)r*GBv_KeLr;<6Mh)
z(wSq4$s2kKw7QTA^NsjQ{(;?C-bLVAIHy`wa+$OzM+hU3P{}^P9&yKdXMvnn@Wi;$
zqRor}ikB8lFQYnHF$%`=Uj>G@^H~v%MDDal{Cpv^7{DlS^+GB_;+b1CI{yixQN`91
z(;16}yN0jPIn62+6-~Nu_(f5QaRuK|Fq#b$LWmJ4R3!jTKzf=|3=skzrw%jpeu7lr
zz<rm?d<RGdJ^wJ%Htc#_M?tDdFa=`#sPGTX3ZH1gyrG9TY&d1u#iSAVGwKzdbV0Gv
zk6ZJLuD-AQRqA}DPJ@%r1&0~L(_8`Kjizt$N6a7q=FY%-(qX=!6<Lh!!(HHOkkihN
z{7yBqJHY+v`<vex@c8T@aTXUh|908^iTLkr*)0gbA>fF-hkf8$pFXt?61Pp&a^Pbx
zraycDKw||NOoI6Vv`c1raHUi6(Co<_y7SGxE%ar@gBg&(>m0KzlF4t75b3<iGRrgU
z9^6<@{Tt1JY>`_XM!ex}46PW1ZhrV>=SzkTd=culH`k4IbV{eK97?<NyhO(@&554`
z%MpiQg<*ZbLcLeJmH@wYk^#q@ihKe0$!0owYOi5wD%ytJ0ycK9R?Y@V%yH0gKX7RJ
z$tS1m;!Zt3pgje}>z5fp9=iSj*ATa-k?+q#g9d`U)Mg)vvxu>P71|^GN`u%k#h|RY
z^0I}h0;Uaxx1(6iIOQa679dN|t?aeL*VJH7KyU~eu)V*u`<;HLCb2;EL6>&F>j@d{
z>Y|9vpfA~eiEedL=3*{fG5sQlRN7W>OFVkfVI3c(ds%MMdx|s?>Z2mcyfm~jns|tK
zuOJPIQLQ@;Hz>uPLY2rmBjW_&gqf0tR{L@47&Nv^)1K#j2vdP4F_S`BH|+pe1SiHw
zsKA$wRT$rKC&xWz(S)qQ^jtC$lt9j`!1M(c2|nmx!Qj2Jx(<&oePAACpierLT3=7<
zn$w;Gs?iV<g5l2=o|>}Xy%|WnPZ!GlO6~x6!If<BTXP84{?i?eDoD9Pxk3dLiIoe0
zF3I3AL+c3z27hg{WY^|8ri0KE2R7yo_-In8CzMX);1JpaeysE(uZTxvP!^Dabdl@v
zwJqgdNiK<_KDs=TN7rw8)E%$LhsBrR!DW3kEg6^vEN2=vRwL+O^~`RH<>)TkWyM#8
z*irK!9MK*r(7UYgea`g5L-LGSb1LmN^87kHou6QPOpW_ZcGjgFWHClU?L%StLH=x`
za81|a49bq3_wn0{Pg{#Bf3HMAHp%rQb&Ak9`^#-mWmThP1w}!LgmYauXVmLoQ4q2$
z#)j0=O_^WU5^CI$T*wL{3xV)+-HW<`d~RR{>bI1eOn;?R_W<Z5dQx9SJu@r%E=R#R
zQX(BqvT*fq)Y5Idc($zKyU=6nU~`6duesRGYN%I=Ph2)NZX0OA!)1+R!5k1n5eXc<
z7K7{)mkj4IpXqNGq6-dY^D()WzmDlK=EOBLB*@OZI>z-{ixx+F(`*-`Y5q~d=@7?z
z_Y?>eR||HIS_Z`;yfz}ME{P6^G<6W!B)^AF3>dDRE_>j9u+UEj6#!V{E0Prk%r@^Q
zs<=e8A*C{rbd~1O?Vlt-r>C3fbquQh)tliY7;A<6i_pgIHAj&-@&<u5WDPV+ons-v
zyWP@9CDtQ*xI@LY;CTP^r$U+L)hGL#s#`5MDe@D~pB3i3OX=tD(Mrmve?A~*5w|(T
z;KD$aI%u%yLW0GKFSlpaPt0wsk^6Ai<<B$anR&YyS@EWKd#sb3H<PupneR(Sx)lm8
zji$tm_ZqTI>jMVrKeuxWiqSBuU4xSw!=gGB9vE5327lC>vc{h&9|d;zwSB`R^-xPk
z_?58pjBHeTU9G;WO7b|Wx_ImFBTWpc?)hpT7wB@a4EqhC+lb&=n-0N4AhN}&CAj?!
zF$0AUfL1a>R{a7;*72Am^l-H^dR$uL*BkM=LE<gtDJ%bKrAyYfbohM9lLaTKT-Irz
zWqlmOvH15uqxkl(+;Fsz!&{Ia6na)25R~(L2uTBp2Thq?<E|fgSAYCKW5$l^h5m{X
zotEv9e3j!=YG{3H<K1ChG?Hoe(Vw&JI&rSh_hU1L_WMn;XR0J6DkAthuUX*vMxpw#
zNg%9jIJhgZvOk{%i*~)MfSTKAuET!F<}X?X-B<Iz1YaB~GTr~S+%4U>sy*lwME+-;
zqpfo;&EZ$ney8t!>=*^Pos1-1Lt#7((zKEK%r701&%thEz(v+}Ju(%h`<DF?uW;LG
z20jXLYFc&v(jNSl@!;I7nm#}OVsQW9-#L*N#w_VW86vYGO=X8EeT>)S7b-Q+PWNZT
z?AG|E8WTGzc*LriAat%f%F&4;>d98}8n;C`4Hw}ZAWp8}LZhK66aQG-l^Y!<BJtb~
z`VGF^x97_4yr%WHpa3qlqZg@mj)Xgeb$u|C&u*nx!Q~iDpL5z%2t(8oRa@sXZQGG<
zwO;f504$7oZ#UfCdczfY^nZYz*EaR-0k=ie4%yCMXlk5fo~+Vz0$W`JtoEZyvpVb}
z=WOQbVrLgVZ&wSu2=1p}XY>QLj>Ko>(@?gFuj+FrKPwIbB{54J!6|(Dr2)h2@16gY
z8=CgCy-gp5Bc|>l+>$!%b)F%1PJZsc7E)r&B@w?gYQiKD08M&#@S5PUY)t)Hj0Ku=
z5o;l!oq+3)4!n{l8wv2CnTNb4%{Z;anueqo7OiLkAoXgVm=f2!7-(1h$CkJFGZD|z
zKoT|*&s_;8y9^WpuP|^ii{~r&3G`aM&l3nI)lp!&MnUJVgFpi%bP1ZG4Az-zzJx3q
z^*?HnWFM=CaBy;oSIe{<IQ)3<tv1sk-0~2}<lr(7a!N_X;jJO6#Htu*e`#5=m>)%m
zNlJH5>3$1O_6UJbp|Y0Zf89{1%2e-vp|{`wuX0AR4|A*mhMD5E!7#e~HR=Oyr0z;U
z;bMa%?#uPaHq`{(D-;Xq!SICI=^Rbm_|g59Nfou2OIH7vG@Qo@N8M-+Wv&|oGW?4*
zyN{f|?w{R5t+hjedaDH^M1d(x53f-yS^~pjNW~$>rSn6YF5~3bx2@FHAv{H+29Xl?
z>Ob@9q91nyefay5UJz1r+##_zrZ<etL`ct#7xdnNZ*OBWF#<1SakW^Xb%;app2bP@
zzIEw*?6k5rC*p`|h3b}zj~jo+dd0Y{BiQ}^eyV}u`Oby-d`IH<+n{%6`>VCVpyIVC
zB*++HcbWg+8;b;?xdItPhQf&=2TSt@_E)FDk50`vq)+3)VMDO3l3e)-%I>n1E0Ea}
z?M3hVXH=yx3a=s^Dz8q2VO!f{E^CKA_Jw7C5M>5tMnU(R1FnWBuk#njTd&Ic`EP_y
zol6|pPRDxvCiR30zK%qX3p3F$fl;^tzeR>6p=PI)(YfKzm2b{}%n^Cm@amuDKb}g|
zKA+O-Aav+g&9ixE8(-#MENbeebz&H}^?XudC9v04ebEfKJHh-nbe0cV(-=^51+673
zTC3txD^)9Y3ZD-i751?ZHKfI+vDcPQfv@7~UK#tfs#R>;XG)?H{fx6ne&jf|71oZF
ziiBHQjSIQC)-o5d%f%~iGyUFD%nS&U30lj2EUTLwEW=($o6@fT$1A?GyF%PM?JfTl
zwLc8WX27Nv2Xko4E2v|yJaDMm8zHhO$NQ$cCL#7ibn8X45<a)!i*M;y#_W{1!4o{~
z=-N224Qo>b74ueFUhP7+akW5m*^}I&Q$u+eTig}=qO?TG%w=88RHpo8lvCoFUE-PB
zfQdDfVsbZ%Bpzv<rLzC=CXLQDiZ``(`@YWiS1RdJ$yu=K^Q%)kJO}=~-N^^GGI)n2
zfqPfA>-A8i7OG(6hgGaY^Bj^nCLn3YvGg;v8WT4$WJKY~-VCx=$v2`^EGH!D7xK^h
zaFtm+)E0pFek^Z5>8f?I<vnweQZCX#ey56m2BPr`C6B0aFzb;*q<TP`V9sL)^8_Zd
z@DDD?K!ot>L-o){m`TG?s+z)rbhheXabX4OQ~&Dzle&-S_p-)N{@!RDXPylEQg8z8
zZu<75J%l|rM(-2etZ$FQ%vhYbcAy!oTb^r#yp*04X5}-uQMRfB>&0fW>-c0!tu^h_
zG%zt|TzUa|({5OL=riQknjYr(;dz$D1J@3RW0TH`Cf>29>hX%!_3+G>_R3Bg$&FrG
z^04cP))>s(ghvi+|Mxd?W$C%SLOZ$Lpb3Af6rabUT32XF_aAYAW6$a1<u)9>Msn8n
z^`y=@gvj}M-%_JL_3~=kXvxH^Hwd@cPAdH#%X<vjA}F=fVNzV3^rfMBmPorHfVx-w
zn>YJue?FhHSoEmem66J*w7OJ>l#<@uHzWfOtG~UBeto|YOM=K|`5R6L%TKrlLr>qd
z5;ws&2+OC4ebrHUY5ojz$)T8cy$^pZs2J0F4~LNI%!)R3@mNm(-tu!AvU7QNtHPbF
zK>Nl^RxUNI$cqa4i<s4lo-6>QG|RKOgP$DV{h8;a*7SF0R!Pm>7cLDZPe!#&J#N-3
zUZB_`UCKQ<r~AI<#~hp2de@bk()2ea1TIGSCx(O{2Fw}oDX+#m<~f%?Jh#Z{V)v*%
z^mZyrAr62#P6n;}dVki2v^)(QMH(jjQ;~O~v`d_PatqY{UnM)xWER^I2LM>SE87YF
zRkHhAI6I+W!yZ2$Q<+6oj^kI6fkSJv;!^ZKa=R2a%N#O%QZ45;*1e~;a(RWt#oRJ!
zT77t5Zu_SvXyb)3zLn<oX`85~`;$?;d`B4sT~W%JrVeYZ_~M3(&|ZLqnBsf`!Ge!$
zd#f<YT??AntL$hyP12^Ynd83uBVKkVE9};-cJrzml3_`wnK(W_3nA9id*zd;e9WFz
z-Iw{)Yi8jm-$>NnqIovin>6{&eT%)s3NDHD#)>L#@~i&LhP?yxa+$5qT(WlCVPg%6
zRv~62H|MhwiQ}UyVUA>1PNxN#-QTlM?Oofm22W6zj<z-sdq#wR&G+JmAJ$lQToGq`
zE*U$AzFOUk3c;f9_UfkF{`_&PoCjR{?C{6G9Gmi8tJ(Di)gSiK&LV`Wr*GUPB6qLR
z@1!U#+q2^6ADCx4@ut9PG{lixpNwo6hj&DID>ufF@6p#*UAdZ-AG;ixrz0zfOlaHr
zEzQcj-^z`mKs0bZV5&$Yqw|JUpDYRLMfOv3c>~4Ft;il40(`O$ugTbAN~nvd!t^^>
z&wW(8gx`2*a6}}BI0`^XnhZiG$Oc49g(}{XP1t)C+|IrarLwu-Qy8l^tl>?kX=xo#
zkMD0tp+{&M8dHF+7Org=wx>hdB{9~OH#9^+%#G4Bunl9QNW~dR(UO2?e6iHF7yQ9i
zfR|N4QB3duoja#NDqKf9lB%DYPL~iKN;obV9bH09&chn&Sp}!Zc}~mu0LLQFFmj|*
zg``d@%2OxoO^94!1m@G@^(xD*skM8ae$|CCslyPa$Glm1pM~(To7o4j^>HITw9JXs
z6JZP-SYr6<i|}QGWC5t1{30@&hQqLncT18gJk;n%H``YuIs-SkZQQP}54CMED{^kR
z`tt_b<~(i`SZlaAhJnoYR@MDUlQLN(Ov0AtTR6g(h{Bw}D2*95DMfJiYpybV8~X(L
zqB58z;a3snZ8L-Urd(C$piJW~VPZCez*UN|HPxhu@lQfg(QBL=RMf**mQCv3dwQ8V
zdC`-cUQgDS<_O(O4+XS@LkxG~-(j<)!2Aixnz*?2KX9oeup+aPV)?P@xtDa;27|LU
z-LeuFH89!>V?IW}<?ttnxt<O17qHb!=AZO36^nH*U%SZ6k+fgWp`_h|pKPILi+6*y
z)v>UJ0sns&?ar0|WBjY9_MfEx^zpwLHFwVbOZw|-ZFO9{zX<l-bi7-iQT{#s0|LgV
AhyVZp


From 492abc0853a78705c238a8675f6d8ea54f1e59aa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= <matthias@mailaender.name>
Date: Sat, 28 Jun 2014 10:37:38 +0200
Subject: [PATCH 5/8] don't spam passed checks

---
 OpenRA.Lint/YamlChecker.cs | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/OpenRA.Lint/YamlChecker.cs b/OpenRA.Lint/YamlChecker.cs
index ba7b1944aa..029e42c04e 100644
--- a/OpenRA.Lint/YamlChecker.cs
+++ b/OpenRA.Lint/YamlChecker.cs
@@ -80,9 +80,6 @@ namespace OpenRA.Lint
 							var customPass = (ILintPass)Game.modData.ObjectCreator
 								.CreateBasic(customPassType);
 
-							if (verbose)
-								Console.WriteLine("Pass: {0}".F(customPassType.ToString()));
-
 							customPass.Run(EmitError, EmitWarning, testMap);
 						}
 						catch (Exception e)

From 95c43132c7d60f88ee2a1b2e568aca62c2a38c3b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= <matthias@mailaender.name>
Date: Sat, 28 Jun 2014 10:38:14 +0200
Subject: [PATCH 6/8] only display lint check name when something goes wrong

---
 OpenRA.Lint/YamlChecker.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OpenRA.Lint/YamlChecker.cs b/OpenRA.Lint/YamlChecker.cs
index 029e42c04e..7c8e3ce487 100644
--- a/OpenRA.Lint/YamlChecker.cs
+++ b/OpenRA.Lint/YamlChecker.cs
@@ -84,7 +84,7 @@ namespace OpenRA.Lint
 						}
 						catch (Exception e)
 						{
-							EmitError("Failed with exception: {0}".F(e));
+							EmitError("{0} failed with exception: {0}".F(customPassType, e));
 						}
 					}
 				}

From a5ac1aa581bf83a391e27539f5353ece56f7c94b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= <matthias@mailaender.name>
Date: Sat, 28 Jun 2014 10:38:33 +0200
Subject: [PATCH 7/8] tell us what you are doing

---
 OpenRA.Lint/YamlChecker.cs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OpenRA.Lint/YamlChecker.cs b/OpenRA.Lint/YamlChecker.cs
index 7c8e3ce487..9011df7476 100644
--- a/OpenRA.Lint/YamlChecker.cs
+++ b/OpenRA.Lint/YamlChecker.cs
@@ -69,7 +69,7 @@ namespace OpenRA.Lint
 				foreach (var testMap in maps)
 				{
 					if (verbose)
-						Console.WriteLine("Map: {0}".F(testMap.Title));
+						Console.WriteLine("Testing map: {0}".F(testMap.Title));
 					testMap.PreloadRules();
 
 					foreach (var customPassType in Game.modData.ObjectCreator

From dcaef3b0e9f182cc852621e693c4e62e3ec9db45 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= <matthias@mailaender.name>
Date: Sat, 28 Jun 2014 10:38:51 +0200
Subject: [PATCH 8/8] explain the strange console message

---
 OpenRA.Lint/YamlChecker.cs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/OpenRA.Lint/YamlChecker.cs b/OpenRA.Lint/YamlChecker.cs
index 9011df7476..4738987ec6 100644
--- a/OpenRA.Lint/YamlChecker.cs
+++ b/OpenRA.Lint/YamlChecker.cs
@@ -20,6 +20,7 @@ namespace OpenRA.Lint
 	{
 		static int errors = 0;
 
+		// mimic Windows compiler error format
 		static void EmitError(string e)
 		{
 			Console.WriteLine("OpenRA.Lint(1,1): Error: {0}", e);