epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cache coloring delegate in AppearsOnRadar.RadarSignatureCells.

Browse Source
This commit is contained in:
RoosterDragon
2017-01-12 21:28:51 +00:00
parent 9c59d7e255
commit 2428b967bf
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
OpenRA.Mods.Common/Traits/Radar/AppearsOnRadar.cs
View File

@@ -9,6 +9,7 @@
*/ */
#endregion #endregion
using System;
using System.Collections.Generic; using System.Collections.Generic;
using System.Drawing; using System.Drawing;
using System.Linq; using System.Linq;
@@ -29,6 +30,9 @@ namespace OpenRA.Mods.Common.Traits.Radar
readonly AppearsOnRadarInfo info; readonly AppearsOnRadarInfo info;
IRadarColorModifier modifier; IRadarColorModifier modifier;
Color currentColor = Color.Transparent;
Func<Pair<CPos, SubCell>, Pair<CPos, Color>> cellToSignature;
public AppearsOnRadar(AppearsOnRadarInfo info) public AppearsOnRadar(AppearsOnRadarInfo info)
{ {
this.info = info; this.info = info;
@@ -48,7 +52,14 @@ namespace OpenRA.Mods.Common.Traits.Radar
if (info.UseLocation) if (info.UseLocation)
return new[] { Pair.New(self.Location, color) }; return new[] { Pair.New(self.Location, color) };
return self.OccupiesSpace.OccupiedCells().Select(c => Pair.New(c.First, color)); // PERF: Cache cellToSignature delegate to avoid allocations as color does not change often.
if (currentColor != color)
{
currentColor = color;
cellToSignature = c => Pair.New(c.First, color);
}
return self.OccupiesSpace.OccupiedCells().Select(cellToSignature);
} }
} }
} }