actually working custom lint passes

OpenRA.Game/ObjectCreator.cs

@@ -84,6 +84,14 @@ namespace OpenRA
 			return ctor.Invoke( a );
 		}
 
+        public IEnumerable<Type> GetTypesImplementing<T>()
+        {
+            var it = typeof(T);
+            return ModAssemblies.Select( ma => ma.First ).Distinct()
+                .SelectMany(ma => ma.GetTypes()
+                .Where(t => t != it && it.IsAssignableFrom(t)));
+        }
+
 		[AttributeUsage( AttributeTargets.Parameter )]
 		public class ParamAttribute : Attribute
 		{

OpenRA.Game/Traits/TraitsInterfaces.cs

@@ -14,6 +14,7 @@ using OpenRA.FileFormats;
 using OpenRA.GameRules;
 using OpenRA.Graphics;
 using OpenRA.Network;
+using System;
 
 namespace OpenRA.Traits
 {
@@ -40,23 +41,24 @@ namespace OpenRA.Traits
     public interface IIssueOrder
     {
         IEnumerable<IOrderTargeter> Orders { get; }
-		Order IssueOrder( Actor self, IOrderTargeter order, Target target, bool queued );
+        Order IssueOrder(Actor self, IOrderTargeter order, Target target, bool queued);
     }
+
     public interface IOrderTargeter
     {
         string OrderID { get; }
         int OrderPriority { get; }
-		bool CanTargetActor( Actor self, Actor target, bool forceAttack, bool forceMove, bool forceQueue, ref string cursor );
+        bool CanTargetActor(Actor self, Actor target, bool forceAttack, bool forceMove, bool forceQueue, ref string cursor);
         bool CanTargetLocation(Actor self, int2 location, List<Actor> actorsAtLocation, bool forceAttack, bool forceQueue, bool forceMove, ref string cursor);
         bool IsQueued { get; }
     }
+
     public interface IResolveOrder { void ResolveOrder(Actor self, Order order); }
-    public interface IValidateOrder { bool OrderValidation(OrderManager orderManager, World world, int clientId, Order order);
-    }
+    public interface IValidateOrder { bool OrderValidation(OrderManager orderManager, World world, int clientId, Order order); }
     public interface IOrderCursor { string CursorForOrder(Actor self, Order order); }
     public interface IOrderVoice { string VoicePhraseForOrder(Actor self, Order order); }
-    public interface ICustomUnitOrderGenerator : IOrderGenerator {};
-	public interface INotifySold { void Selling( Actor self );  void Sold( Actor self ); }
+    public interface ICustomUnitOrderGenerator : IOrderGenerator { };
+    public interface INotifySold { void Selling(Actor self); void Sold(Actor self); }
     public interface INotifyDamage { void Damaged(Actor self, AttackInfo e); }
     public interface INotifyAppliedDamage { void AppliedDamage(Actor self, Actor damaged, AttackInfo e); }
     public interface INotifyBuildComplete { void BuildingComplete(Actor self); }
@@ -64,7 +66,7 @@ namespace OpenRA.Traits
     public interface INotifyCapture { void OnCapture(Actor self, Actor captor, Player oldOwner, Player newOwner); }
     public interface INotifyOtherCaptured { void OnActorCaptured(Actor self, Actor captured, Actor captor, Player oldOwner, Player newOwner); }
     public interface IAcceptSpy { void OnInfiltrate(Actor self, Actor spy); }
-	public interface IStoreOre { int Capacity { get; }}
+    public interface IStoreOre { int Capacity { get; } }
     public interface IToolTip
     {
         string Name();
@@ -107,14 +109,14 @@ namespace OpenRA.Traits
 
     public static class IOccupySpaceExts
     {
-		public static int2 NearestCellTo( this IOccupySpace ios, int2 other )
+        public static int2 NearestCellTo(this IOccupySpace ios, int2 other)
         {
             var nearest = ios.TopLeft;
             var nearestDistance = int.MaxValue;
-			foreach( var cell in ios.OccupiedCells() )
+            foreach (var cell in ios.OccupiedCells())
             {
-				var dist = ( other - cell.First ).LengthSquared;
-				if( dist < nearestDistance )
+                var dist = (other - cell.First).LengthSquared;
+                if (dist < nearestDistance)
                 {
                     nearest = cell.First;
                     nearestDistance = dist;
@@ -130,8 +132,8 @@ namespace OpenRA.Traits
     public interface ISpeedModifier { decimal GetSpeedModifier(); }
     public interface IFirepowerModifier { float GetFirepowerModifier(); }
     public interface ISelectionColorModifier { Color GetSelectionColorModifier(Actor self, Color defaultColor); }
-	public interface IPalette { void InitPalette( WorldRenderer wr ); }
-	public interface IPaletteModifier { void AdjustPalette(Dictionary<string,Palette> b); }
+    public interface IPalette { void InitPalette(WorldRenderer wr); }
+    public interface IPaletteModifier { void AdjustPalette(Dictionary<string, Palette> b); }
     public interface IPips { IEnumerable<PipType> GetPips(Actor self); }
     public interface ITags { IEnumerable<TagType> GetTags(); }
     public interface ISelectionBar { float GetValue(); Color GetColor(); }
@@ -218,7 +220,7 @@ namespace OpenRA.Traits
         IEnumerable<float2> GetCurrentPath();
     }
 
-	public interface IRenderOverlay { void Render( WorldRenderer wr ); }
+    public interface IRenderOverlay { void Render(WorldRenderer wr); }
     public interface INotifyIdle { void TickIdle(Actor self); }
 
     public interface IBlocksBullets { }
@@ -232,10 +234,15 @@ namespace OpenRA.Traits
     public interface ITargetable
     {
         string[] TargetTypes { get; }
-		IEnumerable<int2> TargetableCells( Actor self );
+        IEnumerable<int2> TargetableCells(Actor self);
         bool TargetableBy(Actor self, Actor byActor);
     }
 
-	public interface INotifyStanceChanged { void StanceChanged(Actor self, Player a, Player b, 
-		Stance oldStance, Stance newStance); }
+    public interface INotifyStanceChanged
+    {
+        void StanceChanged(Actor self, Player a, Player b,
+            Stance oldStance, Stance newStance);
+    }
+
+    public interface ILintPass { void Run(Action<string> emitError); }
 }

OpenRA.Mods.RA/Lint/LintBuildablePrerequisites.cs

@@ -0,0 +1,16 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using OpenRA.Traits;
+
+namespace OpenRA.Mods.RA
+{
+    class LintBuildablePrerequisites : ILintPass
+    {
+        public void Run(Action<string> emitError)
+        {
+            emitError("Hello World");
+        }
+    }
+}

OpenRA.Mods.RA/OpenRA.Mods.RA.csproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="3.5" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
@@ -63,6 +63,7 @@
     <Compile Include="Air\FlyCircle.cs" />
     <Compile Include="Buildings\Sellable.cs" />
     <Compile Include="Effects\CashTick.cs" />
+    <Compile Include="Lint\LintBuildablePrerequisites.cs" />
     <Compile Include="ProductionBar.cs" />
     <Compile Include="Render\RenderEditorOnly.cs" />
     <Compile Include="SmokeTrailWhenDamaged.cs" />

RALint/RALint.cs

@@ -30,6 +30,7 @@ namespace RALint
 
 		static int Main(string[] args)
 		{
+            Console.WriteLine("This is teh sucks");
 			try
 			{
 				// bind some nonfatal error handling into FieldLoader, so we don't just *explode*.
@@ -44,6 +45,17 @@ namespace RALint
 					foreach (var traitInfo in actorInfo.Value.Traits.WithInterface<ITraitInfo>())
 						CheckTrait(actorInfo.Value, traitInfo);
 
+                foreach (var customPassType in Game.modData.ObjectCreator
+                    .GetTypesImplementing<ILintPass>())
+                {
+                    var customPass = (ILintPass)Game.modData.ObjectCreator
+                        .CreateBasic(customPassType);
+
+                    Console.WriteLine("CustomPass: {0}".F(customPassType.ToString()));
+
+                    customPass.Run(EmitError);
+                }
+
 				if (errors > 0)
 				{
 					Console.WriteLine("Errors: {0}", errors);