From 25b8e7fefcc7b5df59ac0dcd2255309299ba4dae Mon Sep 17 00:00:00 2001 From: RoosterDragon Date: Sun, 12 Mar 2023 16:25:38 +0000 Subject: [PATCH] Fix CA1834 --- .editorconfig | 3 +++ OpenRA.Game/Support/HttpQueryBuilder.cs | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.editorconfig b/.editorconfig index 993f21a949..76b15ed0f0 100644 --- a/.editorconfig +++ b/.editorconfig @@ -720,6 +720,9 @@ dotnet_diagnostic.CA1832.severity = warning # Use AsSpan or AsMemory instead of Range-based indexers for getting Span or Memory portion of an array. dotnet_diagnostic.CA1833.severity = warning +# Use StringBuilder.Append(char) for single character strings. +dotnet_diagnostic.CA1834.severity = warning + # Prefer the memory-based overloads of ReadAsync/WriteAsync methods in stream-based classes. dotnet_diagnostic.CA1835.severity = warning diff --git a/OpenRA.Game/Support/HttpQueryBuilder.cs b/OpenRA.Game/Support/HttpQueryBuilder.cs index eef28a2d76..fd7fe7918a 100644 --- a/OpenRA.Game/Support/HttpQueryBuilder.cs +++ b/OpenRA.Game/Support/HttpQueryBuilder.cs @@ -37,7 +37,7 @@ namespace OpenRA.Support { var builder = new StringBuilder(url); - builder.Append("?"); + builder.Append('?'); foreach (var parameter in parameters) builder.Append($"{parameter.Key}={parameter.Value}&");