move GetFieldValues to shared LintExts

OpenRA.Mods.Common/Lint/CheckActorReferences.cs

@@ -41,24 +41,10 @@ namespace OpenRA.Mods.Common.Lint
 			}
 		}
 
-		string[] GetFieldValues(ITraitInfo traitInfo, FieldInfo fieldInfo)
-		{
-			var type = fieldInfo.FieldType;
-			if (type == typeof(string))
-				return new string[] { (string)fieldInfo.GetValue(traitInfo) };
-			if (type == typeof(string[]))
-				return (string[])fieldInfo.GetValue(traitInfo);
-
-			emitError("Bad type for reference on {0}.{1}. Supported types: string, string[]"
-				.F(traitInfo.GetType().Name, fieldInfo.Name));
-
-			return new string[] { };
-		}
-
 		void CheckReference<T>(ActorInfo actorInfo, ITraitInfo traitInfo, FieldInfo fieldInfo,
 			IReadOnlyDictionary<string, T> dict, string type)
 		{
-			var values = GetFieldValues(traitInfo, fieldInfo);
+			var values = LintExts.GetFieldValues(traitInfo, fieldInfo, emitError);
 			foreach (var v in values)
 				if (v != null && !dict.ContainsKey(v.ToLowerInvariant()))
 					emitError("{0}.{1}.{2}: Missing {3} `{4}`."

OpenRA.Mods.Common/Lint/LintExts.cs

@@ -0,0 +1,33 @@
+#region Copyright & License Information
+/*
+ * Copyright 2007-2015 The OpenRA Developers (see AUTHORS)
+ * This file is part of OpenRA, which is free software. It is made
+ * available to you under the terms of the GNU General Public License
+ * as published by the Free Software Foundation. For more information,
+ * see COPYING.
+ */
+#endregion
+
+using System;
+using System.Reflection;
+using OpenRA.Traits;
+
+namespace OpenRA.Mods.Common.Lint
+{
+	public class LintExts
+	{
+		public static string[] GetFieldValues(object ruleInfo, FieldInfo fieldInfo, Action<string> emitError)
+		{
+			var type = fieldInfo.FieldType;
+			if (type == typeof(string))
+				return new string[] { (string)fieldInfo.GetValue(ruleInfo) };
+			if (type == typeof(string[]))
+				return (string[])fieldInfo.GetValue(ruleInfo);
+
+			emitError("Bad type for reference on {0}.{1}. Supported types: string, string[]"
+				.F(ruleInfo.GetType().Name, fieldInfo.Name));
+
+			return new string[] { };
+		}
+	}
+}

OpenRA.Mods.Common/OpenRA.Mods.Common.csproj

@@ -186,6 +186,7 @@
     <Compile Include="Lint\CheckTraitPrerequisites.cs" />
     <Compile Include="Lint\CheckDeathTypes.cs" />
     <Compile Include="Lint\LintBuildablePrerequisites.cs" />
+    <Compile Include="Lint\LintExts.cs" />
     <Compile Include="LoadScreens\ModChooserLoadScreen.cs" />
     <Compile Include="Orders\BeaconOrderGenerator.cs" />
     <Compile Include="Orders\DeployOrderTargeter.cs" />