epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix IDE0051

Browse Source
This commit is contained in:
RoosterDragon
2023-02-19 12:29:02 +00:00
committed by Pavel Penev
parent 4991f2f892
commit 2d4119e88d
3 changed files with 4 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.editorconfig
View File

@@ -177,7 +177,10 @@ dotnet_diagnostic.IDE0041.severity = warning
# Make field readonly. # Make field readonly.
dotnet_diagnostic.IDE0044.severity = warning dotnet_diagnostic.IDE0044.severity = warning
# Unused private member. # Remove unused private member.
dotnet_diagnostic.IDE0051.severity = warning
# Remove unread private member.
dotnet_diagnostic.IDE0052.severity = warning dotnet_diagnostic.IDE0052.severity = warning
# Unnecessary value assignment. # Unnecessary value assignment.

17
OpenRA.Game/Graphics/Viewport.cs
View File

@@ -121,23 +121,6 @@ namespace OpenRA.Graphics
public static long LastMoveRunTime = 0; public static long LastMoveRunTime = 0;
public static int2 LastMousePos; public static int2 LastMousePos;
float ClosestTo(float[] collection, float target)
{
var closestValue = collection.First();
var subtractResult = Math.Abs(closestValue - target);
foreach (var element in collection)
{
if (Math.Abs(element - target) < subtractResult)
{
subtractResult = Math.Abs(element - target);
closestValue = element;
}
}
return closestValue;
}
public ScrollDirection GetBlockedDirections() public ScrollDirection GetBlockedDirections()
{ {
var ret = ScrollDirection.None; var ret = ScrollDirection.None;

5
OpenRA.Test/OpenRA.Game/VariableExpressionTest.cs
View File

@@ -42,11 +42,6 @@ namespace OpenRA.Test
Assert.AreEqual(value, new IntegerExpression(expression).Evaluate(testValues), expression); Assert.AreEqual(value, new IntegerExpression(expression).Evaluate(testValues), expression);
} }
void AssertParseFailure(string expression)
{
Assert.Throws(typeof(InvalidDataException), () => new IntegerExpression(expression).Evaluate(testValues), expression);
}
void AssertParseFailure(string expression, string errorMessage) void AssertParseFailure(string expression, string errorMessage)
{ {
var actualErrorMessage = Assert.Throws(typeof(InvalidDataException), var actualErrorMessage = Assert.Throws(typeof(InvalidDataException),