epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure Clear(T) also have a safety check to ensure no listener is attached.

Browse Source 
Move related methods next to each other.
Change Clear(T) to use Array.Fill.
This commit is contained in:
RoosterDragon
2021-09-25 13:51:24 +01:00
committed by abcdefg30
parent 19760b04bd
commit 2ed4cb8aff
3 changed files with 29 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
OpenRA.Game/Map/CellLayerBase.cs
View File

@@ -35,11 +35,6 @@ namespace OpenRA
entries = new T[size.Width * size.Height];
}
public virtual void Clear()
{
Array.Clear(entries, 0, entries.Length);
}
public virtual void CopyValuesFrom(CellLayerBase<T> anotherLayer)
{
if (Size != anotherLayer.Size || GridType != anotherLayer.GridType)
@@ -48,11 +43,16 @@ namespace OpenRA
Array.Copy(anotherLayer.entries, entries, entries.Length);
}
/// <summary>Clears the layer contents with a known value</summary>
public void Clear(T clearValue)
/// <summary>Clears the layer contents with their default value</summary>
public virtual void Clear()
{
for (var i = 0; i < entries.Length; i++)
entries[i] = clearValue;
Array.Clear(entries, 0, entries.Length);
}
/// <summary>Clears the layer contents with a known value</summary>
public virtual void Clear(T clearValue)
{
Array.Fill(entries, clearValue);
}
public IEnumerator<T> GetEnumerator()