epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Hovers desync caused by changing 'WorldVisualOffset' in renderer.

Browse Source
This commit is contained in:
dnqbob
2024-01-12 21:29:00 +08:00
committed by Gustas
parent 2fde98a0d1
commit 32121a38f4
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
OpenRA.Mods.Common/Traits/Render/Hovers.cs
View File

@@ -94,12 +94,6 @@ namespace OpenRA.Mods.Common.Traits.Render
WorldVisualOffset = new WVec(0, 0, fallTickHeight * fallTicks); WorldVisualOffset = new WVec(0, 0, fallTickHeight * fallTicks);
} }
else else
ticks++;
}
IEnumerable<IRenderable> IRenderModifier.ModifyRender(Actor self, WorldRenderer wr, IEnumerable<IRenderable> r)
{
if (!IsTraitDisabled)
{ {
var visualOffset = self.World.Map.DistanceAboveTerrain(self.CenterPosition) >= info.MinHoveringAltitude var visualOffset = self.World.Map.DistanceAboveTerrain(self.CenterPosition) >= info.MinHoveringAltitude
? new WAngle(ticks % (info.Ticks * 4) * stepPercentage).Sin() : 0; ? new WAngle(ticks % (info.Ticks * 4) * stepPercentage).Sin() : 0;
@@ -110,8 +104,12 @@ namespace OpenRA.Mods.Common.Traits.Render
currentHeight = Math.Min(WorldVisualOffset.Z + info.InitialHeight.Length / info.RiseTicks, currentHeight); currentHeight = Math.Min(WorldVisualOffset.Z + info.InitialHeight.Length / info.RiseTicks, currentHeight);
WorldVisualOffset = new WVec(0, 0, currentHeight); WorldVisualOffset = new WVec(0, 0, currentHeight);
ticks++;
} }
}
IEnumerable<IRenderable> IRenderModifier.ModifyRender(Actor self, WorldRenderer wr, IEnumerable<IRenderable> r)
{
return r.Select(a => a.OffsetBy(WorldVisualOffset)); return r.Select(a => a.OffsetBy(WorldVisualOffset));
} }