epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix CA1851

Browse Source
This commit is contained in:
RoosterDragon
2023-07-13 20:08:36 +01:00
committed by abcdefg30
parent 88f830a9e5
commit 3275875ae5
63 changed files with 349 additions and 267 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
OpenRA.Mods.Common/UtilityCommands/ExtractEmmyLuaAPI.cs
View File

@@ -271,7 +271,7 @@ namespace OpenRA.Mods.Common.UtilityCommands
if (isActivity)
Console.WriteLine(" --- *Queued Activity*");
if (requiredTraits.Any())
if (requiredTraits.Length != 0)
Console.WriteLine($" --- **Requires {(requiredTraits.Length == 1 ? "Trait" : "Traits")}:** {requiredTraits.Select(GetDocumentationUrl).JoinWith(", ")}");
if (memberInfo is MethodInfo methodInfo)

7
OpenRA.Mods.Common/UtilityCommands/UpdateMapCommand.cs
View File

@@ -38,7 +38,7 @@ namespace OpenRA.Mods.Common.UtilityCommands
if (folder.OpenPackage(args[1], modData.ModFiles) is not IReadWritePackage package)
throw new FileNotFoundException(args[1]);
IEnumerable<UpdateRule> rules = null;
IReadOnlyCollection<UpdateRule> rules = null;
if (args.Length > 2)
rules = UpdatePath.FromSource(modData.ObjectCreator, args[2]);
@@ -77,9 +77,10 @@ namespace OpenRA.Mods.Common.UtilityCommands
}
var other = UpdatePath.KnownRules(modData.ObjectCreator)
.Where(r => !ruleGroups.Values.Any(g => g.Contains(r)));
.Where(r => !ruleGroups.Values.Any(g => g.Contains(r)))
.ToList();
if (other.Any())
if (other.Count != 0)
{
Console.WriteLine(" Other:");
foreach (var r in other)

11
OpenRA.Mods.Common/UtilityCommands/UpdateModCommand.cs
View File

@@ -32,7 +32,7 @@ namespace OpenRA.Mods.Common.UtilityCommands
// HACK: The engine code assumes that Game.modData is set.
var modData = Game.ModData = utility.ModData;
IEnumerable<UpdateRule> rules = null;
IReadOnlyCollection<UpdateRule> rules = null;
if (args.Length > 1)
rules = UpdatePath.FromSource(modData.ObjectCreator, args[1]);
@@ -71,9 +71,10 @@ namespace OpenRA.Mods.Common.UtilityCommands
}
var other = UpdatePath.KnownRules(modData.ObjectCreator)
.Where(r => !ruleGroups.Values.Any(g => g.Contains(r)));
.Where(r => !ruleGroups.Values.Any(g => g.Contains(r)))
.ToList();
if (other.Any())
if (other.Count != 0)
{
Console.WriteLine(" Other:");
foreach (var r in other)
@@ -111,9 +112,9 @@ namespace OpenRA.Mods.Common.UtilityCommands
PrintSummary(rules, args.Contains("--detailed"));
}
public static void PrintSummary(IEnumerable<UpdateRule> rules, bool detailed)
public static void PrintSummary(IReadOnlyCollection<UpdateRule> rules, bool detailed)
{
var count = rules.Count();
var count = rules.Count;
if (count == 1)
Console.WriteLine("Found 1 API change:");
else