epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix trait linting not providing trait and actor names

Browse Source
This commit is contained in:
Gustas
2023-11-11 16:43:52 +02:00
committed by Matthias Mailänder
parent ff49411bc1
commit 342fc5b0e9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
OpenRA.Mods.Common/Lint/CheckTranslationReference.cs
View File

@@ -35,8 +35,8 @@ namespace OpenRA.Mods.Common.Lint
{ {
foreach (var traitInfo in actorInfo.Value.TraitInfos<TraitInfo>()) foreach (var traitInfo in actorInfo.Value.TraitInfos<TraitInfo>())
{ {
var fields = Utility.GetFields(traitInfo.GetType()); var traitType = traitInfo.GetType();
foreach (var field in fields) foreach (var field in Utility.GetFields(traitType))
{ {
var translationReference = Utility.GetCustomAttributes<TranslationReferenceAttribute>(field, true).FirstOrDefault(); var translationReference = Utility.GetCustomAttributes<TranslationReferenceAttribute>(field, true).FirstOrDefault();
if (translationReference == null) if (translationReference == null)
@@ -48,7 +48,7 @@ namespace OpenRA.Mods.Common.Lint
if (key == null) if (key == null)
{ {
if (!translationReference.Optional) if (!translationReference.Optional)
emitError($"Trait `{traitInfo.InstanceName}` on field `{field.Name}` has an empty translation reference."); emitError($"Actor type `{actorInfo.Key}` has an empty translation reference in trait `{traitType.Name[..^4]}.{field.Name}`.");
continue; continue;
} }