Silence IDE0290.

This rule recommends use of primary constructors. Apply the suggestions on simple POCOs, adjusting some to readonly/structs/records at the same time. For more complex classes, the use of primary constructors is more distracting than helpful, so silence the rule. IDEs can still offer fixes for using primary constructors, but it will not show up as a build issue.

OpenRA.Game/Graphics/Model.cs

@@ -37,19 +37,7 @@ namespace OpenRA.Graphics
 			Func<float> getScale, Func<IModel> getVoxel, Func<WRot> getRotation);
 	}
 
-	public readonly struct ModelRenderData
-	{
-		public readonly int Start;
-		public readonly int Count;
-		public readonly Sheet Sheet;
-
-		public ModelRenderData(int start, int count, Sheet sheet)
-		{
-			Start = start;
-			Count = count;
-			Sheet = sheet;
-		}
-	}
+	public readonly record struct ModelRenderData(int Start, int Count, Sheet Sheet);
 
 	public interface IModelCacheInfo : ITraitInfoInterface { }
 

OpenRA.Game/Graphics/PlatformInterfaces.cs

@@ -179,12 +179,6 @@ namespace OpenRA
 		TriangleList,
 	}
 
-	public readonly struct Range<T>
-	{
-		public readonly T Start, End;
-		public Range(T start, T end) { Start = start; End = end; }
-	}
-
 	public enum WindowMode
 	{
 		Windowed,

OpenRA.Game/Graphics/RenderPostProcessPassVertex.cs

@@ -14,29 +14,10 @@ using System.Runtime.InteropServices;
 namespace OpenRA.Graphics
 {
 	[StructLayout(LayoutKind.Sequential)]
-	public readonly struct RenderPostProcessPassVertex
-	{
-		public readonly float X, Y;
-
-		public RenderPostProcessPassVertex(float x, float y)
-		{
-			X = x; Y = y;
-		}
-	}
+	public readonly record struct RenderPostProcessPassVertex(float X, float Y);
 
 	[StructLayout(LayoutKind.Sequential)]
-	public readonly struct RenderPostProcessPassTexturedVertex
-	{
-		// 3d position
-		public readonly float X, Y;
-		public readonly float S, T;
-
-		public RenderPostProcessPassTexturedVertex(float x, float y, float s, float t)
-		{
-			X = x; Y = y;
-			S = s; T = t;
-		}
-	}
+	public readonly record struct RenderPostProcessPassTexturedVertex(float X, float Y, float S, float T);
 
 	public sealed class RenderPostProcessPassShaderBindings : ShaderBindings
 	{

OpenRA.Game/Graphics/ShaderBindings.cs

@@ -23,21 +23,7 @@ namespace OpenRA.Graphics
 		UInt = 0x1405 // GL_UNSIGNED_INT
 	}
 
-	public readonly struct ShaderVertexAttribute
-	{
-		public readonly string Name;
-		public readonly ShaderVertexAttributeType Type;
-		public readonly int Components;
-		public readonly int Offset;
-
-		public ShaderVertexAttribute(string name, ShaderVertexAttributeType type, int components, int offset)
-		{
-			Name = name;
-			Type = type;
-			Components = components;
-			Offset = offset;
-		}
-	}
+	public readonly record struct ShaderVertexAttribute(string Name, ShaderVertexAttributeType Type, int Components, int Offset);
 
 	public abstract class ShaderBindings : IShaderBindings
 	{