epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Silence IDE0290.

Browse Source 
This rule recommends use of primary constructors. Apply the suggestions on simple POCOs, adjusting some to readonly/structs/records at the same time. For more complex classes, the use of primary constructors is more distracting than helpful, so silence the rule. IDEs can still offer fixes for using primary constructors, but it will not show up as a build issue.
This commit is contained in:
RoosterDragon
2025-04-01 19:26:19 +01:00
committed by Gustas Kažukauskas
parent 3de6a5fd5a
commit 36660b89e9
52 changed files with 161 additions and 707 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
OpenRA.Game/Traits/LintAttributes.cs
View File

@@ -46,33 +46,21 @@ namespace OpenRA.Traits
public sealed class WeaponReferenceAttribute : Attribute { }
[AttributeUsage(AttributeTargets.Field)]
public sealed class SequenceReferenceAttribute : Attribute
public sealed class SequenceReferenceAttribute(
string imageReference = null, bool prefix = false, bool allowNullImage = false,
LintDictionaryReference dictionaryReference = LintDictionaryReference.None) : Attribute
{
// The field name in the same trait info that contains the image name.
public readonly string ImageReference;
public readonly bool Prefix;
public readonly bool AllowNullImage;
public readonly LintDictionaryReference DictionaryReference;
public SequenceReferenceAttribute(string imageReference = null, bool prefix = false, bool allowNullImage = false,
LintDictionaryReference dictionaryReference = LintDictionaryReference.None)
{
ImageReference = imageReference;
Prefix = prefix;
AllowNullImage = allowNullImage;
DictionaryReference = dictionaryReference;
}
public readonly string ImageReference = imageReference;
public readonly bool Prefix = prefix;
public readonly bool AllowNullImage = allowNullImage;
public readonly LintDictionaryReference DictionaryReference = dictionaryReference;
}
[AttributeUsage(AttributeTargets.Field)]
public sealed class CursorReferenceAttribute : Attribute
public sealed class CursorReferenceAttribute(LintDictionaryReference dictionaryReference = LintDictionaryReference.None) : Attribute
{
public readonly LintDictionaryReference DictionaryReference;
public CursorReferenceAttribute(LintDictionaryReference dictionaryReference = LintDictionaryReference.None)
{
DictionaryReference = dictionaryReference;
}
public readonly LintDictionaryReference DictionaryReference = dictionaryReference;
}
[AttributeUsage(AttributeTargets.Field | AttributeTargets.Property)]
@@ -82,13 +70,9 @@ namespace OpenRA.Traits
public sealed class ConsumedConditionReferenceAttribute : Attribute { }
[AttributeUsage(AttributeTargets.Field)]
public sealed class PaletteDefinitionAttribute : Attribute
public sealed class PaletteDefinitionAttribute(bool isPlayerPalette = false) : Attribute
{
public readonly bool IsPlayerPalette;
public PaletteDefinitionAttribute(bool isPlayerPalette = false)
{
IsPlayerPalette = isPlayerPalette;
}
public readonly bool IsPlayerPalette = isPlayerPalette;
}
[AttributeUsage(AttributeTargets.Field)]
@@ -108,12 +92,8 @@ namespace OpenRA.Traits
}
[AttributeUsage(AttributeTargets.Class)]
public sealed class TraitLocationAttribute : Attribute
public sealed class TraitLocationAttribute(SystemActors systemActors) : Attribute
{
public readonly SystemActors SystemActors;
public TraitLocationAttribute(SystemActors systemActors)
{
SystemActors = systemActors;
}
public readonly SystemActors SystemActors = systemActors;
}
}