epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add actor name to ease debugging of invalid bounds.

Browse Source
This commit is contained in:
Matthias Mailänder
2016-05-15 15:24:34 +02:00
parent 95a927a181
commit 3c7871b352
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
OpenRA.Game/Primitives/SpatiallyPartitioned.cs
View File

@@ -31,22 +31,22 @@ namespace OpenRA.Primitives
itemBoundsBins = Exts.MakeArray(rows * cols, _ => new Dictionary<T, Rectangle>()); itemBoundsBins = Exts.MakeArray(rows * cols, _ => new Dictionary<T, Rectangle>());
} }
void ValidateBounds(Rectangle bounds) void ValidateBounds(T actor, Rectangle bounds)
{ {
if (bounds.Width == 0 || bounds.Height == 0) if (bounds.Width == 0 || bounds.Height == 0)
throw new ArgumentException("bounds must be non-empty.", "bounds"); throw new ArgumentException("Bounds of actor {0} are empty.".F(actor), "bounds");
} }
public void Add(T item, Rectangle bounds) public void Add(T item, Rectangle bounds)
{ {
ValidateBounds(bounds); ValidateBounds(item, bounds);
itemBounds.Add(item, bounds); itemBounds.Add(item, bounds);
MutateBins(item, bounds, addItem); MutateBins(item, bounds, addItem);
} }
public void Update(T item, Rectangle bounds) public void Update(T item, Rectangle bounds)
{ {
ValidateBounds(bounds); ValidateBounds(item, bounds);
MutateBins(item, itemBounds[item], removeItem); MutateBins(item, itemBounds[item], removeItem);
MutateBins(item, itemBounds[item] = bounds, addItem); MutateBins(item, itemBounds[item] = bounds, addItem);
} }