epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cache pipImages in the constructor.

Browse Source
This commit is contained in:
Matthias Mailänder
2016-07-03 14:40:14 +02:00
parent 3a7558c273
commit 3e5155fa7d
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
OpenRA.Mods.Common/Traits/Render/SelectionDecorations.cs
View File

@@ -50,12 +50,16 @@ namespace OpenRA.Mods.Common.Traits.Render
static readonly string[] PipStrings = { "pip-empty", "pip-green", "pip-yellow", "pip-red", "pip-gray", "pip-blue", "pip-ammo", "pip-ammoempty" }; static readonly string[] PipStrings = { "pip-empty", "pip-green", "pip-yellow", "pip-red", "pip-gray", "pip-blue", "pip-ammo", "pip-ammoempty" };
public readonly SelectionDecorationsInfo Info; public readonly SelectionDecorationsInfo Info;
readonly Actor self; readonly Actor self;
readonly Animation pipImages;
public SelectionDecorations(Actor self, SelectionDecorationsInfo info) public SelectionDecorations(Actor self, SelectionDecorationsInfo info)
{ {
this.self = self; this.self = self;
Info = info; Info = info;
pipImages = new Animation(self.World, Info.Image);
} }
IEnumerable<WPos> ActivityTargetPath() IEnumerable<WPos> ActivityTargetPath()
@@ -109,7 +113,6 @@ namespace OpenRA.Mods.Common.Traits.Render
if (group == null) if (group == null)
yield break; yield break;
var pipImages = new Animation(self.World, Info.Image);
var pal = wr.Palette(Info.Palette); var pal = wr.Palette(Info.Palette);
pipImages.PlayFetchIndex(Info.GroupSequence, () => (int)group); pipImages.PlayFetchIndex(Info.GroupSequence, () => (int)group);
pipImages.Tick(); pipImages.Tick();
@@ -124,7 +127,6 @@ namespace OpenRA.Mods.Common.Traits.Render
if (!pipSources.Any()) if (!pipSources.Any())
yield break; yield break;
var pipImages = new Animation(self.World, Info.Image);
pipImages.PlayRepeating(PipStrings[0]); pipImages.PlayRepeating(PipStrings[0]);
var pipSize = pipImages.Image.Size.XY.ToInt2(); var pipSize = pipImages.Image.Size.XY.ToInt2();