epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Work around and explain color picker conversion issue.

Browse Source
This commit is contained in:
Paul Chote
2020-04-13 13:54:06 +01:00
committed by reaperrr
parent 33f3038316
commit 417677e6f4
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
OpenRA.Mods.Common/Widgets/Logic/ColorPickerLogic.cs
View File

@@ -72,7 +72,14 @@ namespace OpenRA.Mods.Common.Widgets.Logic
mixer.SetPaletteRange(validator.HsvSaturationRange[0], validator.HsvSaturationRange[1], validator.HsvValueRange[0], validator.HsvValueRange[1]); mixer.SetPaletteRange(validator.HsvSaturationRange[0], validator.HsvSaturationRange[1], validator.HsvValueRange[0], validator.HsvValueRange[1]);
mixer.Set(initialColor); mixer.Set(initialColor);
hueSlider.Value = HueFromColor(initialColor); hueSlider.Value = HueFromColor(initialColor);
onChange(mixer.Color);
// HACK: the value returned from the color mixer will generally not
// be equal to the given initialColor due to its internal RGB -> HSL -> RGB
// conversion. This conversion can sometimes convert a valid initial value
// into an invalid (too close to terrain / another player) color.
// We use the original colour here instead of the mixer color to make sure
// that we keep the player's previous colour value if they don't change anything
onChange(initialColor);
// Setup tab controls // Setup tab controls
var mixerTab = widget.Get("MIXER_TAB"); var mixerTab = widget.Get("MIXER_TAB");