From 442138e1f81930debc713a691980bbfefa86080c Mon Sep 17 00:00:00 2001 From: Chris Forbes Date: Tue, 22 May 2012 19:18:28 +1200 Subject: [PATCH] clean up spurious trait lookup in RenderCargo --- OpenRA.Mods.Cnc/RenderCargo.cs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/OpenRA.Mods.Cnc/RenderCargo.cs b/OpenRA.Mods.Cnc/RenderCargo.cs index ee5b9f926a..8a7a29009a 100644 --- a/OpenRA.Mods.Cnc/RenderCargo.cs +++ b/OpenRA.Mods.Cnc/RenderCargo.cs @@ -36,9 +36,12 @@ namespace OpenRA.Mods.Cnc foreach (var c in cargo.Passengers) { c.Trait().SetPxPosition( c, self.Trait().PxPosition ); - if (facing != null && c.HasTrait()) - c.Trait().Facing = facing.Facing; + + var cargoFacing = c.TraitOrDefault(); + if (facing != null && cargoFacing != null) + cargoFacing.Facing = facing.Facing; } + return r.Concat(cargo.Passengers.SelectMany(a => a.Render())); } }