Remove IFogVisibilityModifier.

OpenRA.Game/Player.cs

@@ -61,7 +61,6 @@ namespace OpenRA
 		public Shroud Shroud;
 		public World World { get; private set; }
 
-		readonly IFogVisibilityModifier[] fogVisibilities;
 		readonly StanceColors stanceColors;
 
 		static FactionInfo ChooseFaction(World world, string name, bool requireSelectable = true)
@@ -134,8 +133,6 @@ namespace OpenRA
 			PlayerActor = world.CreateActor("Player", new TypeDictionary { new OwnerInit(this) });
 			Shroud = PlayerActor.Trait<Shroud>();
 
-			fogVisibilities = PlayerActor.TraitsImplementing<IFogVisibilityModifier>().ToArray();
-
 			// Enable the bot logic on the host
 			IsBot = BotType != null;
 			if (IsBot && Game.IsHost)
@@ -172,28 +169,9 @@ namespace OpenRA
 
 		public bool CanTargetActor(Actor a)
 		{
-			// PERF: Avoid LINQ.
-			if (HasFogVisibility)
-				foreach (var fogVisibility in fogVisibilities)
-					if (fogVisibility.IsVisible(a))
-						return true;
-
 			return CanViewActor(a);
 		}
 
-		public bool HasFogVisibility
-		{
-			get
-			{
-				// PERF: Avoid LINQ.
-				foreach (var fogVisibility in fogVisibilities)
-					if (fogVisibility.HasFogVisibility())
-						return true;
-
-				return false;
-			}
-		}
-
 		public Color PlayerStanceColor(Actor a)
 		{
 			var player = a.World.RenderPlayer ?? a.World.LocalPlayer;

OpenRA.Game/Traits/TraitsInterfaces.cs

@@ -190,12 +190,6 @@ namespace OpenRA.Traits
 	public interface IDefaultVisibility { bool IsVisible(Actor self, Player byPlayer); }
 	public interface IVisibilityModifier { bool IsVisible(Actor self, Player byPlayer); }
 
-	public interface IFogVisibilityModifier
-	{
-		bool IsVisible(Actor actor);
-		bool HasFogVisibility();
-	}
-
 	public interface IOccupySpaceInfo : ITraitInfoInterface
 	{
 		IReadOnlyDictionary<CPos, SubCell> OccupiedCells(ActorInfo info, CPos location, SubCell subCell = SubCell.Any);