Fix yaks trying to attack invalid targets

mods/ra/maps/allies-04/allies04-AI.lua

@@ -236,15 +236,14 @@ end
 
 TargetAndAttack = function(yak, target)
 	if not target or target.IsDead or (not target.IsInWorld) then
-		local enemies = Utils.Where(Map.ActorsInWorld, function(self) return self.Owner == player and self.HasProperty("Health") end)
+		local enemies = Utils.Where(Map.ActorsInWorld, function(self) return self.Owner == player and self.HasProperty("Health") and yak.CanTarget(self) end)
+
 		if #enemies > 0 then
 			target = Utils.Random(enemies)
-		else
-			yak.Wait(DateTime.Seconds(5))
 		end
 	end
 
-	if target and yak.AmmoCount() > 0 then
+	if target and yak.AmmoCount() > 0 and yak.CanTarget(target) then
 		yak.Attack(target)
 	else
 		yak.ReturnToBase()

mods/ra/maps/allies-05a/allies05a-AI.lua

@@ -257,15 +257,13 @@ end
 
 TargetAndAttack = function(yak, target)
 	if not target or target.IsDead or (not target.IsInWorld) then
-		local enemies = Utils.Where(Map.ActorsInWorld, function(self) return self.Owner == greece and self.HasProperty("Health") end)
+		local enemies = Utils.Where(Map.ActorsInWorld, function(self) return self.Owner == greece and self.HasProperty("Health") and yak.CanTarget(self) end)
 		if #enemies > 0 then
 			target = Utils.Random(enemies)
-		else
-			yak.Wait(DateTime.Seconds(5))
 		end
 	end
 
-	if target and yak.AmmoCount() > 0 then
+	if target and yak.AmmoCount() > 0 and yak.CanTarget(target) then
 		yak.Attack(target)
 	else
 		yak.ReturnToBase()

mods/ra/maps/evacuation/evacuation.lua

@@ -75,7 +75,7 @@ end
 Yak = nil
 YakAttack = function(yak)
 	local targets = Map.ActorsInCircle(YakAttackPoint.CenterPosition, WDist.FromCells(10), function(a)
-		return a.Owner == allies1 and not a.IsDead and a ~= Einstein and a ~= Tanya and a ~= Engineer
+		return a.Owner == allies1 and not a.IsDead and a ~= Einstein and a ~= Tanya and a ~= Engineer and yak.CanTarget(a)
 	end)
 
 	if (#targets > 0) then

mods/ra/maps/exodus/exodus.lua

@@ -204,31 +204,30 @@ ManageSovietUnits = function()
 	Utils.Do(scatteredUnits, IdleHunt)
 end
 
-AircraftTargets = function()
+AircraftTargets = function(yak)
 	local targets = Utils.Where(Map.ActorsInWorld, function(a)
-		return (a.Owner == allies1 or a.Owner == allies2) and a.HasProperty("Health")
+		return (a.Owner == allies1 or a.Owner == allies2) and a.HasProperty("Health") and yak.CanTarget(a)
 	end)
 
-	-- prefer mobile units
+	-- Prefer mobile units
 	table.sort(targets, function(a, b) return a.HasProperty("Move") and not b.HasProperty("Move") end)
 
 	return targets
 end
 
 YakAttack = function(yak, target)
-	if not target or target.IsDead or (not target.IsInWorld) then
+	if not target or target.IsDead or (not target.IsInWorld) or (not yak.CanTarget(target)) then
-		local targets = AircraftTargets()
+		local targets = AircraftTargets(yak)
 		if #targets > 0 then
 			target = Utils.Random(targets)
-		else
-			yak.Wait(DateTime.Seconds(5))
 		end
 	end
 
-	if target and yak.AmmoCount() > 0 then
+	if target and yak.AmmoCount() > 0 and yak.CanTarget(target) then
 		yak.Attack(target)
 	else
-		yak.ReturnToBase() -- includes yak.Resupply()
+		-- Includes yak.Resupply()
+		yak.ReturnToBase()
 	end
 
 	yak.CallFunc(function()