From 47fa9e496d9e94af8b4a0705d73c25193c147494 Mon Sep 17 00:00:00 2001 From: Paul Chote Date: Mon, 1 Jan 2018 11:50:03 +0000 Subject: [PATCH] Fix tooltips not showing for frozen actors with dead backing actors. This also documents some old bugs. --- OpenRA.Mods.Common/Widgets/ViewportControllerWidget.cs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/OpenRA.Mods.Common/Widgets/ViewportControllerWidget.cs b/OpenRA.Mods.Common/Widgets/ViewportControllerWidget.cs index 3e7109870b..9e7d42c780 100644 --- a/OpenRA.Mods.Common/Widgets/ViewportControllerWidget.cs +++ b/OpenRA.Mods.Common/Widgets/ViewportControllerWidget.cs @@ -252,11 +252,17 @@ namespace OpenRA.Mods.Common.Widgets if (frozen != null) { var actor = frozen.Actor; - if (actor != null && actor.TraitsImplementing().All(t => t.IsVisible(actor, world.RenderPlayer))) + + // HACK: This leaks the cloak state through the fog (cloaked buildings will not show tooltips) + if (actor == null || actor.TraitsImplementing().All(t => t.IsVisible(actor, world.RenderPlayer))) { FrozenActorTooltip = frozen; + + // HACK: This leaks the tooltip state through the fog + // This will cause issues for any downstream mods that use IProvideTooltipInfo on enemy actors if (frozen.Actor != null) ActorTooltipExtra = frozen.Actor.TraitsImplementing().ToArray(); + TooltipType = WorldTooltipType.FrozenActor; return; }