diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20200202/RemoveInitialFacingHardcoding.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20200202/RemoveInitialFacingHardcoding.cs index a767592227..055afb537a 100644 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20200202/RemoveInitialFacingHardcoding.cs +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20200202/RemoveInitialFacingHardcoding.cs @@ -53,8 +53,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules nonVTOLs.Add(Tuple.Create(actorNode.Key, actorNode.Location.Filename)); } - - yield break; } } } diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20200503/ChangeTargetLineDelayToMilliseconds.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20200503/ChangeTargetLineDelayToMilliseconds.cs index b18790b81e..cf000b8027 100644 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20200503/ChangeTargetLineDelayToMilliseconds.cs +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20200503/ChangeTargetLineDelayToMilliseconds.cs @@ -26,11 +26,8 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules foreach (var dltt in actorNode.ChildrenMatching("DrawLineToTarget", includeRemovals: false)) { var delayNode = dltt.LastChildMatching("Delay", false); - if (delayNode != null) - { - if (Exts.TryParseIntegerInvariant(delayNode.Value.Value, out var delay)) - delayNode.ReplaceValue((delay * 1000 / 25).ToString()); - } + if (delayNode != null && Exts.TryParseIntegerInvariant(delayNode.Value.Value, out var delay)) + delayNode.ReplaceValue((delay * 1000 / 25).ToString()); } yield break; diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20200503/RemoveTurnToDock.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20200503/RemoveTurnToDock.cs index 7cadae0bac..ea1127b8b2 100644 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20200503/RemoveTurnToDock.cs +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20200503/RemoveTurnToDock.cs @@ -50,8 +50,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules turningAircraft.Add(Tuple.Create(actorNode.Key, actorNode.Location.Filename)); } - - yield break; } } } diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20200503/SplitDamagedByTerrain.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20200503/SplitDamagedByTerrain.cs index cc3b9b5d95..aef1096e36 100644 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20200503/SplitDamagedByTerrain.cs +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20200503/SplitDamagedByTerrain.cs @@ -28,8 +28,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules if (damaged.RemoveNodes("StartOnThreshold") > 0) yield return $"'StartOnThreshold' was removed from {actorNode.Key} ({actorNode.Location.Filename}) without replacement.\n"; } - - yield break; } } } diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20210321/ReplaceCrateSecondsWithTicks.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20210321/ReplaceCrateSecondsWithTicks.cs index 8f9800a482..88d24af1ab 100644 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20210321/ReplaceCrateSecondsWithTicks.cs +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20210321/ReplaceCrateSecondsWithTicks.cs @@ -35,9 +35,7 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules } foreach (var scNode in actorNode.ChildrenMatching("ScaredyCat")) - { scNode.RenameChildrenMatching("PanicLength", "PanicDuration"); - } yield break; } diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ExplicitSequenceFilenames.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ExplicitSequenceFilenames.cs index cddc97500c..e288a9b40c 100644 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ExplicitSequenceFilenames.cs +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ExplicitSequenceFilenames.cs @@ -315,8 +315,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules foreach (var sequenceNode in imageNode.Value.Nodes.ToList()) if (implicitInheritedSequences.Contains(sequenceNode.Key) && !sequenceNode.Value.Nodes.Any()) imageNode.RemoveNode(sequenceNode); - - yield break; } void ProcessNode(ModData modData, MiniYamlNode sequenceNode, MiniYamlNode resolvedSequenceNode, string imageName) diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ProductionTabsWidgetAddTabButtonCollection.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ProductionTabsWidgetAddTabButtonCollection.cs index d5fa294b5a..23324ba1a3 100644 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ProductionTabsWidgetAddTabButtonCollection.cs +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20221203/ProductionTabsWidgetAddTabButtonCollection.cs @@ -33,11 +33,7 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules } if (buttonCollection != null) - { chromeNode.AddNode(new MiniYamlNode("ArrowButton", buttonCollection)); - } - - yield break; } } } diff --git a/OpenRA.Mods.Common/UpdateRules/Rules/20221203/TextNotificationsDisplayWidgetRemoveTime.cs b/OpenRA.Mods.Common/UpdateRules/Rules/20221203/TextNotificationsDisplayWidgetRemoveTime.cs index dbcaa42a98..4ca6d3859f 100644 --- a/OpenRA.Mods.Common/UpdateRules/Rules/20221203/TextNotificationsDisplayWidgetRemoveTime.cs +++ b/OpenRA.Mods.Common/UpdateRules/Rules/20221203/TextNotificationsDisplayWidgetRemoveTime.cs @@ -32,8 +32,6 @@ namespace OpenRA.Mods.Common.UpdateRules.Rules var durationMilliseconds = field.NodeValue() * 40; field.ReplaceValue(FieldSaver.FormatValue(durationMilliseconds)); } - - yield break; } } }