From bdb7c80f42f9df78d9c74761094e26663996e1ac Mon Sep 17 00:00:00 2001
From: reaperrr <thereaperrr@aol.com>
Date: Thu, 26 May 2016 08:16:22 +0200
Subject: [PATCH 1/4] Moved FlashTarget to Mods.Common

There is nothing remaining in OpenRA.Game using this.
---
 OpenRA.Game/OpenRA.Game.csproj                                 | 1 -
 OpenRA.Mods.Common/Activities/Demolish.cs                      | 1 +
 OpenRA.Mods.Common/Activities/ExternalCaptureActor.cs          | 2 +-
 {OpenRA.Game => OpenRA.Mods.Common}/Effects/FlashTarget.cs     | 3 ++-
 OpenRA.Mods.Common/OpenRA.Mods.Common.csproj                   | 1 +
 OpenRA.Mods.Common/Traits/ProximityCapturable.cs               | 2 +-
 OpenRA.Mods.Common/Widgets/WorldInteractionControllerWidget.cs | 1 -
 7 files changed, 6 insertions(+), 5 deletions(-)
 rename {OpenRA.Game => OpenRA.Mods.Common}/Effects/FlashTarget.cs (95%)

diff --git a/OpenRA.Game/OpenRA.Game.csproj b/OpenRA.Game/OpenRA.Game.csproj
index 6d8eda9288..95bd44c8ab 100644
--- a/OpenRA.Game/OpenRA.Game.csproj
+++ b/OpenRA.Game/OpenRA.Game.csproj
@@ -108,7 +108,6 @@
     <Compile Include="Download.cs" />
     <Compile Include="Effects\AsyncAction.cs" />
     <Compile Include="Effects\DelayedAction.cs" />
-    <Compile Include="Effects\FlashTarget.cs" />
     <Compile Include="Effects\IEffect.cs" />
     <Compile Include="Game.cs" />
     <Compile Include="GameRules\ActorInfo.cs" />
diff --git a/OpenRA.Mods.Common/Activities/Demolish.cs b/OpenRA.Mods.Common/Activities/Demolish.cs
index a1d95ca248..ea44d67ca7 100644
--- a/OpenRA.Mods.Common/Activities/Demolish.cs
+++ b/OpenRA.Mods.Common/Activities/Demolish.cs
@@ -11,6 +11,7 @@
 
 using System.Linq;
 using OpenRA.Effects;
+using OpenRA.Mods.Common.Effects;
 using OpenRA.Mods.Common.Traits;
 using OpenRA.Traits;
 
diff --git a/OpenRA.Mods.Common/Activities/ExternalCaptureActor.cs b/OpenRA.Mods.Common/Activities/ExternalCaptureActor.cs
index 7518758b33..f14477185d 100644
--- a/OpenRA.Mods.Common/Activities/ExternalCaptureActor.cs
+++ b/OpenRA.Mods.Common/Activities/ExternalCaptureActor.cs
@@ -10,7 +10,7 @@
 #endregion
 
 using OpenRA.Activities;
-using OpenRA.Effects;
+using OpenRA.Mods.Common.Effects;
 using OpenRA.Mods.Common.Traits;
 using OpenRA.Traits;
 
diff --git a/OpenRA.Game/Effects/FlashTarget.cs b/OpenRA.Mods.Common/Effects/FlashTarget.cs
similarity index 95%
rename from OpenRA.Game/Effects/FlashTarget.cs
rename to OpenRA.Mods.Common/Effects/FlashTarget.cs
index 0bcb5e4ecd..9c59bfdc94 100644
--- a/OpenRA.Game/Effects/FlashTarget.cs
+++ b/OpenRA.Mods.Common/Effects/FlashTarget.cs
@@ -11,9 +11,10 @@
 
 using System.Collections.Generic;
 using System.Linq;
+using OpenRA.Effects;
 using OpenRA.Graphics;
 
-namespace OpenRA.Effects
+namespace OpenRA.Mods.Common.Effects
 {
 	public class FlashTarget : IEffect
 	{
diff --git a/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj b/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
index 4cb22e0ca3..5669bfe180 100644
--- a/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
+++ b/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
@@ -151,6 +151,7 @@
     <Compile Include="Effects\Contrail.cs" />
     <Compile Include="Effects\ContrailFader.cs" />
     <Compile Include="Effects\CrateEffect.cs" />
+    <Compile Include="Effects\FlashTarget.cs" />
     <Compile Include="Effects\FloatingText.cs" />
     <Compile Include="Effects\GravityBomb.cs" />
     <Compile Include="Effects\LaserZap.cs" />
diff --git a/OpenRA.Mods.Common/Traits/ProximityCapturable.cs b/OpenRA.Mods.Common/Traits/ProximityCapturable.cs
index dd3100d8ec..135ff4bcd8 100644
--- a/OpenRA.Mods.Common/Traits/ProximityCapturable.cs
+++ b/OpenRA.Mods.Common/Traits/ProximityCapturable.cs
@@ -12,8 +12,8 @@
 using System.Collections.Generic;
 using System.Drawing;
 using System.Linq;
-using OpenRA.Effects;
 using OpenRA.Graphics;
+using OpenRA.Mods.Common.Effects;
 using OpenRA.Mods.Common.Graphics;
 using OpenRA.Traits;
 
diff --git a/OpenRA.Mods.Common/Widgets/WorldInteractionControllerWidget.cs b/OpenRA.Mods.Common/Widgets/WorldInteractionControllerWidget.cs
index 5e4c0e913f..965bdd7796 100644
--- a/OpenRA.Mods.Common/Widgets/WorldInteractionControllerWidget.cs
+++ b/OpenRA.Mods.Common/Widgets/WorldInteractionControllerWidget.cs
@@ -12,7 +12,6 @@
 using System.Collections.Generic;
 using System.Drawing;
 using System.Linq;
-using OpenRA.Effects;
 using OpenRA.Graphics;
 using OpenRA.Mods.Common.Effects;
 using OpenRA.Orders;

From 54891ed4bd54e2b5f4861c7c6cafac9cff7bd50f Mon Sep 17 00:00:00 2001
From: reaperrr <thereaperrr@aol.com>
Date: Thu, 26 May 2016 11:37:39 +0200
Subject: [PATCH 2/4] Moved RejectsOrders and ValidateOrder from Game to
 Mods.Common

---
 OpenRA.Game/OpenRA.Game.csproj                                 | 2 --
 OpenRA.Mods.Common/OpenRA.Mods.Common.csproj                   | 2 ++
 {OpenRA.Game => OpenRA.Mods.Common}/Traits/RejectsOrders.cs    | 3 ++-
 .../Traits/World}/ValidateOrder.cs                             | 3 ++-
 4 files changed, 6 insertions(+), 4 deletions(-)
 rename {OpenRA.Game => OpenRA.Mods.Common}/Traits/RejectsOrders.cs (95%)
 rename {OpenRA.Game/Traits => OpenRA.Mods.Common/Traits/World}/ValidateOrder.cs (96%)

diff --git a/OpenRA.Game/OpenRA.Game.csproj b/OpenRA.Game/OpenRA.Game.csproj
index 95bd44c8ab..10ced73a1f 100644
--- a/OpenRA.Game/OpenRA.Game.csproj
+++ b/OpenRA.Game/OpenRA.Game.csproj
@@ -174,13 +174,11 @@
     <Compile Include="Traits\DrawLineToTarget.cs" />
     <Compile Include="Traits\EditorTilesetFilter.cs" />
     <Compile Include="Traits\LintAttributes.cs" />
-    <Compile Include="Traits\RejectsOrders.cs" />
     <Compile Include="Traits\Player\DeveloperMode.cs" />
     <Compile Include="Traits\Player\PlayerResources.cs" />
     <Compile Include="Traits\Selectable.cs" />
     <Compile Include="Traits\Target.cs" />
     <Compile Include="Traits\TraitsInterfaces.cs" />
-    <Compile Include="Traits\ValidateOrder.cs" />
     <Compile Include="Traits\World\Faction.cs" />
     <Compile Include="Traits\World\ResourceType.cs" />
     <Compile Include="Traits\World\ScreenShaker.cs" />
diff --git a/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj b/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
index 5669bfe180..d1d2b31854 100644
--- a/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
+++ b/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
@@ -456,6 +456,7 @@
     <Compile Include="Traits\Render\WithVoxelBarrel.cs" />
     <Compile Include="Traits\Render\WithVoxelBody.cs" />
     <Compile Include="Traits\Render\WithVoxelTurret.cs" />
+    <Compile Include="Traits\RejectsOrders.cs" />
     <Compile Include="Traits\Repairable.cs" />
     <Compile Include="Traits\RepairableNear.cs" />
     <Compile Include="Traits\RepairsBridges.cs" />
@@ -507,6 +508,7 @@
     <Compile Include="Traits\World\PaletteFromCurrentTileset.cs" />
     <Compile Include="Traits\World\PaletteFromFile.cs" />
     <Compile Include="Traits\World\PaletteFromRGBA.cs" />
+    <Compile Include="Traits\World\ValidateOrder.cs" />
     <Compile Include="Traits\World\VoxelNormalsPalette.cs" />
     <Compile Include="Pathfinder\CellInfoLayerPool.cs" />
     <Compile Include="Pathfinder\Constants.cs" />
diff --git a/OpenRA.Game/Traits/RejectsOrders.cs b/OpenRA.Mods.Common/Traits/RejectsOrders.cs
similarity index 95%
rename from OpenRA.Game/Traits/RejectsOrders.cs
rename to OpenRA.Mods.Common/Traits/RejectsOrders.cs
index dcc985109a..3b842d8438 100644
--- a/OpenRA.Game/Traits/RejectsOrders.cs
+++ b/OpenRA.Mods.Common/Traits/RejectsOrders.cs
@@ -10,8 +10,9 @@
 #endregion
 
 using System.Collections.Generic;
+using OpenRA.Traits;
 
-namespace OpenRA.Traits
+namespace OpenRA.Mods.Common.Traits
 {
 	[Desc("Can be used to make a unit partly uncontrollable by the player.")]
 	public class RejectsOrdersInfo : ITraitInfo
diff --git a/OpenRA.Game/Traits/ValidateOrder.cs b/OpenRA.Mods.Common/Traits/World/ValidateOrder.cs
similarity index 96%
rename from OpenRA.Game/Traits/ValidateOrder.cs
rename to OpenRA.Mods.Common/Traits/World/ValidateOrder.cs
index 1948226d4d..04f17262cc 100644
--- a/OpenRA.Game/Traits/ValidateOrder.cs
+++ b/OpenRA.Mods.Common/Traits/World/ValidateOrder.cs
@@ -10,8 +10,9 @@
 #endregion
 
 using OpenRA.Network;
+using OpenRA.Traits;
 
-namespace OpenRA.Traits
+namespace OpenRA.Mods.Common.Traits
 {
 	[Desc("Used to detect exploits. Attach this to the world actor.")]
 	public class ValidateOrderInfo : TraitInfo<ValidateOrder> { }

From e7517e7bfa596a34d357e675cff51d742d77fda6 Mon Sep 17 00:00:00 2001
From: reaperrr <thereaperrr@aol.com>
Date: Thu, 26 May 2016 11:38:39 +0200
Subject: [PATCH 3/4] Moved DrawLineToTarget from Game to Mods.Common

---
 OpenRA.Game/OpenRA.Game.csproj                                 | 1 -
 OpenRA.Mods.Common/OpenRA.Mods.Common.csproj                   | 1 +
 .../Traits/Render}/DrawLineToTarget.cs                         | 3 ++-
 OpenRA.Mods.RA/Traits/Infiltration/Infiltrates.cs              | 1 +
 4 files changed, 4 insertions(+), 2 deletions(-)
 rename {OpenRA.Game/Traits => OpenRA.Mods.Common/Traits/Render}/DrawLineToTarget.cs (98%)

diff --git a/OpenRA.Game/OpenRA.Game.csproj b/OpenRA.Game/OpenRA.Game.csproj
index 10ced73a1f..3731498e8a 100644
--- a/OpenRA.Game/OpenRA.Game.csproj
+++ b/OpenRA.Game/OpenRA.Game.csproj
@@ -171,7 +171,6 @@
     <Compile Include="Support\Program.cs" />
     <Compile Include="Sync.cs" />
     <Compile Include="TraitDictionary.cs" />
-    <Compile Include="Traits\DrawLineToTarget.cs" />
     <Compile Include="Traits\EditorTilesetFilter.cs" />
     <Compile Include="Traits\LintAttributes.cs" />
     <Compile Include="Traits\Player\DeveloperMode.cs" />
diff --git a/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj b/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
index d1d2b31854..4e439a1e40 100644
--- a/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
+++ b/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
@@ -456,6 +456,7 @@
     <Compile Include="Traits\Render\WithVoxelBarrel.cs" />
     <Compile Include="Traits\Render\WithVoxelBody.cs" />
     <Compile Include="Traits\Render\WithVoxelTurret.cs" />
+    <Compile Include="Traits\Render\DrawLineToTarget.cs" />
     <Compile Include="Traits\RejectsOrders.cs" />
     <Compile Include="Traits\Repairable.cs" />
     <Compile Include="Traits\RepairableNear.cs" />
diff --git a/OpenRA.Game/Traits/DrawLineToTarget.cs b/OpenRA.Mods.Common/Traits/Render/DrawLineToTarget.cs
similarity index 98%
rename from OpenRA.Game/Traits/DrawLineToTarget.cs
rename to OpenRA.Mods.Common/Traits/Render/DrawLineToTarget.cs
index 3407762c79..421400a43f 100644
--- a/OpenRA.Game/Traits/DrawLineToTarget.cs
+++ b/OpenRA.Mods.Common/Traits/Render/DrawLineToTarget.cs
@@ -12,8 +12,9 @@
 using System.Collections.Generic;
 using System.Drawing;
 using OpenRA.Graphics;
+using OpenRA.Traits;
 
-namespace OpenRA.Traits
+namespace OpenRA.Mods.Common.Traits
 {
 	public class DrawLineToTargetInfo : ITraitInfo
 	{
diff --git a/OpenRA.Mods.RA/Traits/Infiltration/Infiltrates.cs b/OpenRA.Mods.RA/Traits/Infiltration/Infiltrates.cs
index 31f7a813ba..9687f65b50 100644
--- a/OpenRA.Mods.RA/Traits/Infiltration/Infiltrates.cs
+++ b/OpenRA.Mods.RA/Traits/Infiltration/Infiltrates.cs
@@ -15,6 +15,7 @@ using System.Linq;
 using OpenRA.Mods.Common;
 using OpenRA.Mods.Common.Activities;
 using OpenRA.Mods.Common.Orders;
+using OpenRA.Mods.Common.Traits;
 using OpenRA.Mods.RA.Activities;
 using OpenRA.Traits;
 

From 95795c51980ac4c6cfda84c204568c073e6c815c Mon Sep 17 00:00:00 2001
From: reaperrr <thereaperrr@aol.com>
Date: Thu, 26 May 2016 11:54:48 +0200
Subject: [PATCH 4/4] Move EditorTilesetFilter to Mods.Common

---
 OpenRA.Game/OpenRA.Game.csproj                                 | 1 -
 OpenRA.Mods.Common/OpenRA.Mods.Common.csproj                   | 1 +
 .../Traits/EditorTilesetFilter.cs                              | 3 ++-
 3 files changed, 3 insertions(+), 2 deletions(-)
 rename {OpenRA.Game => OpenRA.Mods.Common}/Traits/EditorTilesetFilter.cs (92%)

diff --git a/OpenRA.Game/OpenRA.Game.csproj b/OpenRA.Game/OpenRA.Game.csproj
index 3731498e8a..ae3b220ae1 100644
--- a/OpenRA.Game/OpenRA.Game.csproj
+++ b/OpenRA.Game/OpenRA.Game.csproj
@@ -171,7 +171,6 @@
     <Compile Include="Support\Program.cs" />
     <Compile Include="Sync.cs" />
     <Compile Include="TraitDictionary.cs" />
-    <Compile Include="Traits\EditorTilesetFilter.cs" />
     <Compile Include="Traits\LintAttributes.cs" />
     <Compile Include="Traits\Player\DeveloperMode.cs" />
     <Compile Include="Traits\Player\PlayerResources.cs" />
diff --git a/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj b/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
index 4e439a1e40..458e1700b5 100644
--- a/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
+++ b/OpenRA.Mods.Common/OpenRA.Mods.Common.csproj
@@ -325,6 +325,7 @@
     <Compile Include="Traits\CustomSelectionSize.cs" />
     <Compile Include="Traits\Demolishable.cs" />
     <Compile Include="Traits\DetectCloaked.cs" />
+    <Compile Include="Traits\EditorTilesetFilter.cs" />
     <Compile Include="Traits\EjectOnDeath.cs" />
     <Compile Include="Traits\EmitInfantryOnSell.cs" />
     <Compile Include="Traits\EngineerRepair.cs" />
diff --git a/OpenRA.Game/Traits/EditorTilesetFilter.cs b/OpenRA.Mods.Common/Traits/EditorTilesetFilter.cs
similarity index 92%
rename from OpenRA.Game/Traits/EditorTilesetFilter.cs
rename to OpenRA.Mods.Common/Traits/EditorTilesetFilter.cs
index fc78d4fdcf..db6f9da191 100644
--- a/OpenRA.Game/Traits/EditorTilesetFilter.cs
+++ b/OpenRA.Mods.Common/Traits/EditorTilesetFilter.cs
@@ -10,8 +10,9 @@
 #endregion
 
 using System.Collections.Generic;
+using OpenRA.Traits;
 
-namespace OpenRA.Traits
+namespace OpenRA.Mods.Common.Traits
 {
 	public class EditorTilesetFilterInfo : TraitInfo<EditorTilesetFilter>
 	{