Added FacingInit and AltitudeInit. Used in Mobile/Aircraft/Husks. Refactored Production, SpyPlane, Paratroopers and LeavesHusk

OpenRA.Game/ActorInitializer.cs

@@ -36,15 +36,55 @@ namespace OpenRA
 		{
 			return dict.Get<T>().Value( world );
 		}
-	}
-
-	public interface IActorInit
-	{
+		
+		public bool Contains<T>()
+			where T : IActorInit
+		{
+			return dict.Contains<T>();
+		}
 	}
+	
+	public interface IActorInit {}
 
 	public interface IActorInit<T> : IActorInit
 	{
 		T Value( World world );
+	}
+	
+	public class FacingInit : IActorInit<int>
+	{
+		[FieldFromYamlKey]
+		public readonly int value = 128;
+		
+		public FacingInit() { }
+		
+		public FacingInit( int init )
+		{
+			value = init;
+		}
+		
+		public int Value( World world )
+		{
+			return value;	
+		}
+	}
+	
+	public class AltitudeInit : IActorInit<int>
+	{
+		[FieldFromYamlKey]
+		public readonly int value = 0;
+		
+		public AltitudeInit() { }
+		
+		public AltitudeInit( int init )
+		{
+			value = init;
+		}
+		
+		public int Value( World world )
+		{
+			return value;	
+		}
 	}
 
 	public class LocationInit : IActorInit<int2>

OpenRA.Game/Traits/Mobile.cs

@@ -77,6 +77,8 @@ namespace OpenRA.Traits
 			this.self = init.self;
 			this.Info = info;
 			this.__fromCell = this.__toCell = init.Get<LocationInit,int2>();
+			this.Facing = init.Contains<FacingInit>() ? init.Get<FacingInit,int>() : info.InitialFacing;
+			this.Altitude = init.Contains<AltitudeInit>() ? init.Get<AltitudeInit,int>() : 0;
 			
 			shroud = self.World.WorldActor.traits.Get<Shroud>();
 			uim = self.World.WorldActor.traits.Get<UnitInfluence>();

OpenRA.Game/Traits/Production.cs

@@ -12,6 +12,7 @@ using System.Collections.Generic;
 using System.Linq;
 using OpenRA.GameRules;
 using System.Drawing;
+using OpenRA.FileFormats;
 
 namespace OpenRA.Traits
 {
@@ -55,8 +56,11 @@ namespace OpenRA.Traits
 			if( location == null || self.World.WorldActor.traits.Get<UnitInfluence>().GetUnitsAt( location.Value ).Any() )
 				return false;
 
-			var newUnit = self.World.CreateActor( producee.Name, location.Value, self.Owner );
-			newUnit.traits.Get<IFacing>().Facing = CreationFacing( self, newUnit ); ;
+			var newUnit = self.World.CreateActor( producee.Name, new TypeDictionary
+			{
+				new LocationInit( location.Value ),
+				new OwnerInit( self.Owner ),
+			});
 
 			var pi = self.Info.Traits.Get<ProductionInfo>();
 			var rp = self.traits.GetOrDefault<RallyPoint>();