epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix RCS1068

Browse Source
This commit is contained in:
RoosterDragon
2023-03-18 12:19:22 +00:00
committed by Gustas
parent 1a299d10ed
commit 4fe2ed3df0
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.editorconfig
View File

@@ -983,6 +983,9 @@ dotnet_diagnostic.RCS1059.severity = warning
# Remove empty 'finally' clause. # Remove empty 'finally' clause.
dotnet_diagnostic.RCS1066.severity = warning dotnet_diagnostic.RCS1066.severity = warning
# Simplify logical negation.
dotnet_diagnostic.RCS1068.severity = warning
# Remove empty namespace declaration. # Remove empty namespace declaration.
dotnet_diagnostic.RCS1072.severity = warning dotnet_diagnostic.RCS1072.severity = warning

2
OpenRA.Game/Support/VariableExpression.cs
View File

@@ -676,7 +676,7 @@ namespace OpenRA.Support
else if (t.Closes != Grouping.None) else if (t.Closes != Grouping.None)
{ {
Token temp; Token temp;
while (!((temp = s.Pop()).Opens != Grouping.None)) while ((temp = s.Pop()).Opens == Grouping.None)
yield return temp; yield return temp;
} }
else if (t.OperandSides == Sides.None) else if (t.OperandSides == Sides.None)

4
OpenRA.Mods.Common/Traits/BotModules/BotModuleLogic/MinelayerBotModule.cs
View File

@@ -149,7 +149,7 @@ namespace OpenRA.Mods.Common.Traits
foreach (var minelayer in minelayers) foreach (var minelayer in minelayers)
{ {
var cells = pathFinder.FindPathToTargetCell(minelayer.Actor, new[] { minelayer.Actor.Location }, enemy.Location, BlockedByActor.Immovable, laneBias: false); var cells = pathFinder.FindPathToTargetCell(minelayer.Actor, new[] { minelayer.Actor.Location }, enemy.Location, BlockedByActor.Immovable, laneBias: false);
if (cells != null && !(cells.Count == 0)) if (cells != null && cells.Count != 0)
{ {
AIUtils.BotDebug($"{player}: try find a location to lay mine."); AIUtils.BotDebug($"{player}: try find a location to lay mine.");
EnqueueConflictPosition(cells[cells.Count / 2]); EnqueueConflictPosition(cells[cells.Count / 2]);
@@ -193,7 +193,7 @@ namespace OpenRA.Mods.Common.Traits
foreach (var minelayer in minelayers) foreach (var minelayer in minelayers)
{ {
var cells = pathFinder.FindPathToTargetCell(minelayer.Actor, new[] { minelayer.Actor.Location }, minelayingPosition, BlockedByActor.Immovable, laneBias: false); var cells = pathFinder.FindPathToTargetCell(minelayer.Actor, new[] { minelayer.Actor.Location }, minelayingPosition, BlockedByActor.Immovable, laneBias: false);
if (cells != null && !(cells.Count == 0)) if (cells != null && cells.Count != 0)
{ {
orderedActors.Add(minelayer.Actor); orderedActors.Add(minelayer.Actor);