epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changes to improve understandability of code

Browse Source
This commit is contained in:
David Jiménez
2015-03-28 07:36:39 +01:00
committed by reaperrr
parent 1d9c6251c0
commit 5109848215
2 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
OpenRA.Game/Traits/World/ActorMap.cs
View File

@@ -212,35 +212,36 @@ namespace OpenRA.Traits
yield return i.Actor; yield return i.Actor;
} }
public bool HasFreeSubCell(CPos a, bool checkTransient = true) public bool HasFreeSubCell(CPos cell, bool checkTransient = true)
{ {
return FreeSubCell(a, SubCell.Any, checkTransient) != SubCell.Invalid; return FreeSubCell(cell, SubCell.Any, checkTransient) != SubCell.Invalid;
} }
public SubCell FreeSubCell(CPos a, SubCell preferredSubCell = SubCell.Any, bool checkTransient = true) public SubCell FreeSubCell(CPos cell, SubCell preferredSubCell = SubCell.Any, bool checkTransient = true)
{ {
if (preferredSubCell > SubCell.Any && !AnyUnitsAt(a, preferredSubCell, checkTransient)) if (preferredSubCell > SubCell.Any && !AnyUnitsAt(cell, preferredSubCell, checkTransient))
return preferredSubCell; return preferredSubCell;
if (!AnyUnitsAt(a)) if (!AnyUnitsAt(cell))
return map.DefaultSubCell; return map.DefaultSubCell;
for (var i = (int)SubCell.First; i < map.SubCellOffsets.Length; i++) for (var i = (int)SubCell.First; i < map.SubCellOffsets.Length; i++)
if (i != (int)preferredSubCell && !AnyUnitsAt(a, (SubCell)i, checkTransient)) if (i != (int)preferredSubCell && !AnyUnitsAt(cell, (SubCell)i, checkTransient))
return (SubCell)i; return (SubCell)i;
return SubCell.Invalid; return SubCell.Invalid;
} }
public SubCell FreeSubCell(CPos a, SubCell preferredSubCell, Func<Actor, bool> checkIfBlocker) public SubCell FreeSubCell(CPos cell, SubCell preferredSubCell, Func<Actor, bool> checkIfBlocker)
{ {
if (preferredSubCell > SubCell.Any && !AnyUnitsAt(a, preferredSubCell, checkIfBlocker)) if (preferredSubCell > SubCell.Any && !AnyUnitsAt(cell, preferredSubCell, checkIfBlocker))
return preferredSubCell; return preferredSubCell;
if (!AnyUnitsAt(a)) if (!AnyUnitsAt(cell))
return map.DefaultSubCell; return map.DefaultSubCell;
for (var i = (int)SubCell.First; i < map.SubCellOffsets.Length; i++) for (var i = (int)SubCell.First; i < map.SubCellOffsets.Length; i++)
if (i != (int)preferredSubCell && !AnyUnitsAt(a, (SubCell)i, checkIfBlocker)) if (i != (int)preferredSubCell && !AnyUnitsAt(cell, (SubCell)i, checkIfBlocker))
return (SubCell)i; return (SubCell)i;
return SubCell.Invalid; return SubCell.Invalid;
} }
@@ -325,7 +326,7 @@ namespace OpenRA.Traits
} }
} }
void RemoveInfluenceInner(ref InfluenceNode influenceNode, Actor toRemove) static void RemoveInfluenceInner(ref InfluenceNode influenceNode, Actor toRemove)
{ {
if (influenceNode == null) if (influenceNode == null)
return; return;

3
OpenRA.Game/WPos.cs
View File

@@ -35,6 +35,9 @@ namespace OpenRA
public static bool operator ==(WPos me, WPos other) { return me.X == other.X && me.Y == other.Y && me.Z == other.Z; } public static bool operator ==(WPos me, WPos other) { return me.X == other.X && me.Y == other.Y && me.Z == other.Z; }
public static bool operator !=(WPos me, WPos other) { return !(me == other); } public static bool operator !=(WPos me, WPos other) { return !(me == other); }
/// <summary>
/// Returns the linear interpolation between points 'a' and 'b'
/// </summary>
public static WPos Lerp(WPos a, WPos b, int mul, int div) { return a + (b - a) * mul / div; } public static WPos Lerp(WPos a, WPos b, int mul, int div) { return a + (b - a) * mul / div; }
public static WPos LerpQuadratic(WPos a, WPos b, WAngle pitch, int mul, int div) public static WPos LerpQuadratic(WPos a, WPos b, WAngle pitch, int mul, int div)