epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix possible endless loop in replay recorder while opening save file.

Browse Source
This commit is contained in:
Vapre
2021-03-02 21:11:34 +01:00
committed by teinarss
parent 27ddae3df9
commit 52d39db84a
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
OpenRA.Game/Network/ReplayRecorder.cs
View File

@@ -19,6 +19,9 @@ namespace OpenRA.Network
{ {
sealed class ReplayRecorder sealed class ReplayRecorder
{ {
// Arbitrary value.
const int CreateReplayFileMaxRetryCount = 128;
public ReplayMetadata Metadata; public ReplayMetadata Metadata;
BinaryWriter writer; BinaryWriter writer;
Func<string> chooseFilename; Func<string> chooseFilename;
@@ -59,7 +62,12 @@ namespace OpenRA.Network
{ {
file = File.Create(fullFilename); file = File.Create(fullFilename);
} }
catch (IOException) { } catch (IOException ex)
{
if (id > CreateReplayFileMaxRetryCount)
throw new ArgumentException(
"Error creating replay file \"{0}.orarep\"".F(filename), ex);
}
} }
file.WriteArray(initialContent); file.WriteArray(initialContent);