epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #8309 from Mailaender/lint-neutral

Browse Source 
Added a lint rule to check if Neutral is set up correctly
This commit is contained in:
Pavel Penev
2015-06-01 02:06:06 +03:00
parent 926900d3f9 98afa922ac
commit 53f26adb88
14 changed files with 13 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
OpenRA.Mods.Common/Lint/CheckPlayers.cs
View File

@@ -22,22 +22,26 @@ namespace OpenRA.Mods.Common.Lint
var players = new MapPlayers(map.PlayerDefinitions).Players;
var playerNames = players.Values.Select(p => p.Name);
foreach (var player in players)
foreach (var ally in player.Value.Allies)
foreach (var player in players.Values)
{
foreach (var ally in player.Allies)
if (!playerNames.Contains(ally))
emitError("Allies contains player {0} that is not in list.".F(ally));
foreach (var player in players)
foreach (var enemy in player.Value.Enemies)
foreach (var enemy in player.Enemies)
if (!playerNames.Contains(enemy))
emitError("Enemies contains player {0} that is not in list.".F(enemy));
if (player.OwnsWorld && (player.Enemies.Any() || player.Allies.Any()))
emitWarning("The player {0} owning the world should not have any allies or enemies.".F(player.Name));
}
var worldActor = map.Rules.Actors["world"];
var races = worldActor.Traits.WithInterface<CountryInfo>().Select(c => c.Race);
foreach (var player in players)
if (!string.IsNullOrWhiteSpace(player.Value.Race) && player.Value.Race != "Random" && !races.Contains(player.Value.Race))
emitError("Invalid race {0} chosen for player {1}.".F(player.Value.Race, player.Value.Name));
foreach (var player in players.Values)
if (!string.IsNullOrWhiteSpace(player.Race) && !races.Contains(player.Race))
emitError("Invalid race {0} chosen for player {1}.".F(player.Race, player.Name));
if (worldActor.Traits.Contains<MPStartLocationsInfo>())
{