From 587cd34b92bddea1a9cb0d78c0f8b0378c6bcaef Mon Sep 17 00:00:00 2001 From: Chris Forbes Date: Sat, 24 Apr 2010 23:14:42 +1200 Subject: [PATCH] similar for HasUnitOnBuild. don't go digging through mod assemblies yourself, please --- OpenRA.Game/Traits/HasUnitOnBuild.cs | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/OpenRA.Game/Traits/HasUnitOnBuild.cs b/OpenRA.Game/Traits/HasUnitOnBuild.cs index dd18c2b722..62cd4ace9e 100644 --- a/OpenRA.Game/Traits/HasUnitOnBuild.cs +++ b/OpenRA.Game/Traits/HasUnitOnBuild.cs @@ -28,21 +28,9 @@ namespace OpenRA.Traits + info.SpawnOffset, self.Owner); var unitTrait = unit.traits.Get(); unitTrait.Facing = info.Facing; - - if (info.InitialActivity != null) - { - foreach (var mod in Game.ModAssemblies) - { - var fullTypeName = mod.Second + "." + info.InitialActivity; - var activity = (IActivity)mod.First.CreateInstance(fullTypeName); - if (activity == null) continue; - unit.QueueActivity( activity ); - return; - } - - throw new InvalidOperationException("Cannot locate Activity: `{0}`".F(info.InitialActivity)); - } + if (info.InitialActivity != null) + unit.QueueActivity(Game.CreateObject(info.InitialActivity)); }); } }