From 6613db7a152eb083762f8442aca1c865b118f294 Mon Sep 17 00:00:00 2001 From: reaperrr Date: Mon, 14 Sep 2015 16:36:56 +0200 Subject: [PATCH] Fix RotationPaletteEffect tileset validity check If Tilesets was empty but ExcludeTilesets was not, it would always return false even though that combination is supposed to mean only the excluded tileset(s) is/are not valid for this effect. --- .../Traits/PaletteEffects/RotationPaletteEffect.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/OpenRA.Mods.Common/Traits/PaletteEffects/RotationPaletteEffect.cs b/OpenRA.Mods.Common/Traits/PaletteEffects/RotationPaletteEffect.cs index 34c63d6a80..443ac7af26 100644 --- a/OpenRA.Mods.Common/Traits/PaletteEffects/RotationPaletteEffect.cs +++ b/OpenRA.Mods.Common/Traits/PaletteEffects/RotationPaletteEffect.cs @@ -66,6 +66,9 @@ namespace OpenRA.Mods.Common.Traits if (info.Tilesets.Count == 0 && info.ExcludeTilesets.Count == 0) return true; + if (info.Tilesets.Count == 0 && !info.ExcludeTilesets.Contains(tilesetId)) + return true; + return info.Tilesets.Contains(tilesetId) && !info.ExcludeTilesets.Contains(tilesetId); }