Add a lint check for trait placement on hardcoded actor names.

OpenRA.Mods.Common/Traits/Render/CustomTerrainDebugOverlay.cs

@@ -17,6 +17,7 @@ using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.Traits
 {
+	[TraitLocation(SystemActors.World)]
 	[Desc("Displays custom terrain types.")]
 	class CustomTerrainDebugOverlayInfo : TraitInfo
 	{

OpenRA.Mods.Common/Traits/Render/ProductionBar.cs

@@ -31,7 +31,7 @@ namespace OpenRA.Mods.Common.Traits.Render
 
 			// No queues available - check for classic production queues
 			if (queue == null)
-				queue = rules.Actors["player"].TraitInfos<ProductionQueueInfo>().FirstOrDefault(q => ProductionType == q.Type);
+				queue = rules.Actors[SystemActors.Player].TraitInfos<ProductionQueueInfo>().FirstOrDefault(q => ProductionType == q.Type);
 
 			if (queue == null)
 				throw new YamlException("Can't find a queue with ProductionType '{0}'".F(ProductionType));

OpenRA.Mods.Common/Traits/Render/VeteranProductionIconOverlay.cs

@@ -15,6 +15,7 @@ using OpenRA.Traits;
 
 namespace OpenRA.Mods.Common.Traits.Render
 {
+	[TraitLocation(SystemActors.Player)]
 	[Desc("Attach this to the player actor. When attached, enables all actors possessing the ProducibleWithLevel ",
 		"trait to have their production queue icons render with an overlay defined in this trait. ",
 		"The icon change occurs when ProducibleWithLevel.Prerequisites are met.")]