split unit smoke out into WithSmoke trait; remove duplication

mods/cnc/rules/civilian.yaml

@@ -283,5 +283,4 @@ VICE:
 		PrimaryWeapon: Chemspray
 	AttackWander:
 	RenderUnit:
-		Smokes: False
 	WithMuzzleFlash:

mods/cnc/rules/defaults.yaml

@@ -29,6 +29,7 @@
 		Notification: unitlost.aud
 	AttackMove:
 	AcceptsCloakCrate:
+	WithSmoke:
 
 ^Tank:
 	AppearsOnRadar:
@@ -61,6 +62,7 @@
 		Notification: unitlost.aud
 	AttackMove:
 	AcceptsCloakCrate:
+	WithSmoke:
 
 ^Helicopter:
 	AppearsOnRadar:

mods/cnc/rules/ships.yaml

@@ -25,6 +25,7 @@ BOAT:
 	RenderGunboat:
 	AutoTarget:
 		AllowMovement: false
+	WithSmoke:
 
 LST:
 	Inherits: ^Ship

mods/ra/rules/aircraft.yaml

@@ -10,7 +10,6 @@ BADR:
 		ROT: 5
 		Speed: 16
 	RenderUnit:
-		Smokes: no
 	WithShadow:
 	IronCurtainable:
 	Cargo:
@@ -53,7 +52,6 @@ BADR.bomber:
 		Ammo: 7
 	RenderUnit:
 		Image: badr
-		Smokes: no
 	WithShadow:
 	IronCurtainable:	
 	-Selectable:
@@ -108,7 +106,6 @@ MIG:
 		Speed: 20
 		RearmBuildings: afld
 	RenderUnit:
-		Smokes: no
 	WithShadow:
 	LimitedAmmo:
 		Ammo: 8
@@ -159,7 +156,6 @@ YAK:
 		ROT: 5
 		Speed: 16
 	RenderUnit:
-		Smokes: no
 	WithShadow:
 	LimitedAmmo:
 		Ammo: 18
@@ -251,7 +247,6 @@ HELI:
 		ROT: 4
 		Speed: 16
 	RenderUnit:
-		Smokes: no
 	WithRotor:
 		Offset: 0,0,0,-2
 	WithShadow:
@@ -295,7 +290,6 @@ HIND:
 		ROT: 4
 		Speed: 12
 	RenderUnit:
-		Smokes: no
 	WithRotor:
 	WithShadow:
 	LimitedAmmo:
@@ -321,7 +315,6 @@ U2:
 		ROT: 7
 		Speed: 40
 	RenderUnit:
-		Smokes: no
 	WithShadow:
 	IronCurtainable:
 	-Selectable:

mods/ra/rules/defaults.yaml

@@ -30,6 +30,7 @@
 	GivesBounty:
 	GpsDot:
 		String:Vehicle
+	WithSmoke:
 
 ^Tank:
 	AppearsOnRadar:
@@ -63,6 +64,7 @@
 	GivesBounty:
 	GpsDot:
 		String:Vehicle
+	WithSmoke:
 
 ^Infantry:
 	AppearsOnRadar:
@@ -129,6 +131,7 @@
 	GivesBounty:
 	GpsDot:
 		String:Ship
+	WithSmoke:
 
 ^Plane:
 	AppearsOnRadar: