From 5f86f56bed614766167539c2c5375acf75cb9244 Mon Sep 17 00:00:00 2001 From: abcdefg30 Date: Thu, 9 Jun 2022 14:21:44 +0200 Subject: [PATCH] Reduce code duplication in AttackFollow --- OpenRA.Mods.Common/Traits/Attack/AttackFollow.cs | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/OpenRA.Mods.Common/Traits/Attack/AttackFollow.cs b/OpenRA.Mods.Common/Traits/Attack/AttackFollow.cs index 73cd0525a5..2f847776b7 100644 --- a/OpenRA.Mods.Common/Traits/Attack/AttackFollow.cs +++ b/OpenRA.Mods.Common/Traits/Attack/AttackFollow.cs @@ -46,11 +46,11 @@ namespace OpenRA.Mods.Common.Traits bool opportunityForceAttack; bool opportunityTargetIsPersistentTarget; - public void SetRequestedTarget(in Target target, bool isForceAttack = false) + public void SetRequestedTarget(in Target target, bool isForceAttack = false, Activity requestedTargetPreset = null) { RequestedTarget = target; requestedForceAttack = isForceAttack; - requestedTargetPresetForActivity = null; + requestedTargetPresetForActivity = requestedTargetPreset; } public void ClearRequestedTarget() @@ -164,11 +164,7 @@ namespace OpenRA.Mods.Common.Traits // We can improve responsiveness for turreted actors by preempting // the last order (usually a move) and setting the target immediately if (!queued) - { - RequestedTarget = target; - requestedForceAttack = forceAttack; - requestedTargetPresetForActivity = activity; - } + SetRequestedTarget(target, forceAttack, activity); } public override void OnStopOrder(Actor self)