epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use HashSets instead of .Distinct

Browse Source 
And don't cast to array / list where unnecessary
This commit is contained in:
Gustas
2024-01-22 15:02:53 +02:00
committed by atlimit8
parent 53e4d0dd87
commit 6026d088c8
6 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
OpenRA.Mods.Common/Traits/SupportPowers/GrantExternalConditionPower.cs
View File

@@ -96,11 +96,12 @@ namespace OpenRA.Mods.Common.Traits
public IEnumerable<Actor> UnitsInRange(CPos xy)
{
var tiles = CellsMatching(xy, footprint, info.Dimensions);
var units = new List<Actor>();
var units = new HashSet<Actor>();
foreach (var t in tiles)
units.AddRange(Self.World.ActorMap.GetActorsAt(t));
foreach (var a in Self.World.ActorMap.GetActorsAt(t))
units.Add(a);
return units.Distinct().Where(a =>
return units.Where(a =>
{
if (!info.ValidRelationships.HasRelationship(Self.Owner.RelationshipWith(a.Owner)))
return false;