From 60e86f563c2ef7c4b8f444dc8b114700739925aa Mon Sep 17 00:00:00 2001 From: RoosterDragon Date: Fri, 11 Aug 2023 19:40:34 +0100 Subject: [PATCH] Fix RCS1084 --- .editorconfig | 3 +++ OpenRA.Mods.Cnc/Activities/Teleport.cs | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.editorconfig b/.editorconfig index 361f6249e2..f3edc3d70b 100644 --- a/.editorconfig +++ b/.editorconfig @@ -998,6 +998,9 @@ dotnet_diagnostic.RCS1074.severity = warning # Use 'Count' property instead of 'Any' method. dotnet_diagnostic.RCS1080.severity = warning +# Use coalesce expression instead of conditional expression. +dotnet_diagnostic.RCS1084.severity = warning + # Remove empty region. dotnet_diagnostic.RCS1091.severity = warning diff --git a/OpenRA.Mods.Cnc/Activities/Teleport.cs b/OpenRA.Mods.Cnc/Activities/Teleport.cs index e431525b90..ae2b6a5119 100644 --- a/OpenRA.Mods.Cnc/Activities/Teleport.cs +++ b/OpenRA.Mods.Cnc/Activities/Teleport.cs @@ -128,7 +128,7 @@ namespace OpenRA.Mods.Cnc.Activities if (pos.CanEnterCell(destination) && teleporter.Owner.Shroud.IsExplored(destination)) return destination; - var max = maximumDistance != null ? maximumDistance.Value : teleporter.World.Map.Grid.MaximumTileSearchRange; + var max = maximumDistance ?? teleporter.World.Map.Grid.MaximumTileSearchRange; foreach (var tile in self.World.Map.FindTilesInCircle(destination, max)) { if (teleporter.Owner.Shroud.IsExplored(tile)