epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use TryGetValue instead of ContainsKey and a lookup for cached sounds

Browse Source
This commit is contained in:
abcdefg30
2022-05-18 14:16:35 +02:00
committed by atlimit8
parent ea04a7fec5
commit 660130653c
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
OpenRA.Game/Sound/Sound.cs
View File

@@ -401,9 +401,8 @@ namespace OpenRA
if (!string.IsNullOrEmpty(name) && (p == null || p == p.World.LocalPlayer)) if (!string.IsNullOrEmpty(name) && (p == null || p == p.World.LocalPlayer))
{ {
if (currentNotifications.ContainsKey(name)) if (currentNotifications.TryGetValue(name, out var currentNotification))
{ {
var currentNotification = currentNotifications[name];
if (!currentNotification.Complete) if (!currentNotification.Complete)
{ {
if (pool.AllowInterrupt) if (pool.AllowInterrupt)
@@ -412,9 +411,8 @@ namespace OpenRA
return false; return false;
} }
} }
else if (currentSounds.ContainsKey(actorId)) else if (currentSounds.TryGetValue(actorId, out var currentSound))
{ {
var currentSound = currentSounds[actorId];
if (!currentSound.Complete) if (!currentSound.Complete)
{ {
if (pool.AllowInterrupt) if (pool.AllowInterrupt)