epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

LayMines: fixed occasional incorrect mine position when using BeginMinefield order

Browse Source 
When laying mine with PreLayDelay > 0, end activity's tick immediately. That means don't try to immediately move to next cell.

This change unifies the behavior with scenario when a mine is laid without any PreLayDelay.
This commit is contained in:
michaeldgg2
2023-07-18 20:48:14 +02:00
committed by Gustas
parent 42baa0c42f
commit 66cf912da0
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
OpenRA.Mods.Common/Activities/LayMines.cs
View File

@@ -76,10 +76,10 @@ namespace OpenRA.Mods.Common.Activities
if (LayMine(self)) if (LayMine(self))
{ {
if (minelayer.Info.AfterLayingDelay > 0) if (minelayer.Info.AfterLayingDelay > 0)
{
QueueChild(new Wait(minelayer.Info.AfterLayingDelay)); QueueChild(new Wait(minelayer.Info.AfterLayingDelay));
return false;
} // The tick has to end now, because otherwise a next cell is picked and Move activity is queued (which will change minelayer's location in current tick).
return false;
} }
} }
@@ -201,6 +201,9 @@ namespace OpenRA.Mods.Common.Activities
self.World.AddFrameEndTask(w => self.World.AddFrameEndTask(w =>
{ {
if (!CanLayMine(self, self.Location))
return;
var mine = w.CreateActor(minelayer.Info.Mine, new TypeDictionary var mine = w.CreateActor(minelayer.Info.Mine, new TypeDictionary
{ {
new LocationInit(self.Location), new LocationInit(self.Location),