Implemented IEquatable<T> to speed up equality comparisons.

Actor, CPos, CVec, WAngle, WPos, WRange, WRot and WVec structs now implement IEquatable<T> which means unboxing/casting costs can be eliminated.

Also simplified the ToString method by concatenating components directly rather than using a format string since the overhead is a bit high for simple cases like this.
This commit is contained in:
RoosterDragon
2014-05-21 04:29:56 +01:00
parent db08357e36
commit 67594b844a
8 changed files with 44 additions and 56 deletions

View File

@@ -15,7 +15,7 @@ namespace OpenRA
/// <summary>
/// 1D angle - 1024 units = 360 degrees.
/// </summary>
public struct WAngle
public struct WAngle : IEquatable<WAngle>
{
public readonly int Angle;
@@ -37,11 +37,8 @@ namespace OpenRA
public override int GetHashCode() { return Angle.GetHashCode(); }
public override bool Equals(object obj)
{
var o = obj as WAngle?;
return o != null && o == this;
}
public bool Equals(WAngle other) { return other == this; }
public override bool Equals(object obj) { return obj is WAngle && Equals((WAngle)obj); }
public int Sin() { return new WAngle(Angle - 256).Cos(); }
@@ -103,7 +100,7 @@ namespace OpenRA
public float RendererRadians() { return (float)(Angle * Math.PI / 512f); }
public float RendererDegrees() { return Angle * 0.3515625f; }
public override string ToString() { return "{0}".F(Angle); }
public override string ToString() { return Angle.ToString(); }
static int[] CosineTable =
{