epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid Count() when Any() could be used (CA1827)

Browse Source
This commit is contained in:
Matthias Mailänder
2022-09-06 18:08:25 +02:00
committed by Pavel Penev
parent 7ba6a49378
commit 67aa0cdede
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.editorconfig
View File

@@ -156,6 +156,9 @@ dotnet_diagnostic.CA1825.severity = warning
# Do not use Enumerable methods on indexable collections. Instead use the collection directly. # Do not use Enumerable methods on indexable collections. Instead use the collection directly.
dotnet_diagnostic.CA1826.severity = warning dotnet_diagnostic.CA1826.severity = warning
# Count() is used where Any() could be used instead to improve performance.
dotnet_diagnostic.CA1827.severity = warning
# Use string.Contains(char) instead of string.Contains(string) with single characters. # Use string.Contains(char) instead of string.Contains(string) with single characters.
dotnet_diagnostic.CA1847.severity = warning dotnet_diagnostic.CA1847.severity = warning

2
OpenRA.Mods.Common/UtilityCommands/ExtractSettingsDocsCommand.cs
View File

@@ -59,7 +59,7 @@ namespace OpenRA.Mods.Common.UtilityCommands
foreach (var section in sections.OrderBy(s => s.Key)) foreach (var section in sections.OrderBy(s => s.Key))
{ {
var fields = section.Value.GetType().GetFields(); var fields = section.Value.GetType().GetFields();
if (fields.Length > 0 && fields.Where(field => field.GetCustomAttributes<DescAttribute>(false).Length > 0).Count() > 0) if (fields.Any(field => field.GetCustomAttributes<DescAttribute>(false).Length > 0))
Console.WriteLine($"## {section.Key}"); Console.WriteLine($"## {section.Key}");
else else
Console.WriteLine(); Console.WriteLine();