From 6b04dbc2105b0b35a67d478c9f7bb9d7b9431615 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20Mail=C3=A4nder?= Date: Sun, 8 Feb 2026 11:33:25 +0100 Subject: [PATCH] Point to the log for long stack traces. --- .../Logic/Editor/MapGeneratorToolLogic.cs | 20 +++++++++++-------- mods/common/fluent/common.ftl | 7 +++++-- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/OpenRA.Mods.Common/Widgets/Logic/Editor/MapGeneratorToolLogic.cs b/OpenRA.Mods.Common/Widgets/Logic/Editor/MapGeneratorToolLogic.cs index bed7f8488d..2c3f4473a5 100644 --- a/OpenRA.Mods.Common/Widgets/Logic/Editor/MapGeneratorToolLogic.cs +++ b/OpenRA.Mods.Common/Widgets/Logic/Editor/MapGeneratorToolLogic.cs @@ -25,11 +25,16 @@ namespace OpenRA.Mods.Common.Widgets.Logic public class MapGeneratorToolLogic : ChromeLogic { [FluentReference("name")] - const string StrGenerated = "notification-map-generator-generated"; + const string MapGenerated = "notification-map-generator-generated"; + [FluentReference] - const string StrFailed = "notification-map-generator-failed"; + const string MapGeneratorFailedTitle = "dialog-notification-map-generator-failed.title"; + [FluentReference] - const string StrFailedCancel = "label-map-generator-failed-cancel"; + const string MapGeneratorFailedPrompt = "dialog-notification-map-generator-failed.prompt"; + + [FluentReference] + const string MapGeneratorFailedCancel = "dialog-notification-map-generator-failed.cancel"; readonly EditorActionManager editorActionManager; readonly World world; @@ -239,14 +244,13 @@ namespace OpenRA.Mods.Common.Widgets.Logic void DisplayError(Exception e) { - // For any non-MapGenerationException, include more information for debugging purposes. - var message = e is MapGenerationException ? e.Message : e.ToString(); + var message = e is MapGenerationException ? e.Message : MapGeneratorFailedPrompt; Log.Write("debug", e); ConfirmationDialogs.ButtonPrompt(modData, - title: StrFailed, + title: MapGeneratorFailedTitle, text: message, onCancel: () => { }, - cancelText: StrFailedCancel); + cancelText: MapGeneratorFailedCancel); } void GenerateMap() @@ -318,7 +322,7 @@ namespace OpenRA.Mods.Common.Widgets.Logic editorActorLayer, false); - var description = FluentProvider.GetMessage(StrGenerated, + var description = FluentProvider.GetMessage(MapGenerated, "name", FluentProvider.GetMessage(generator.Name)); var action = new RandomMapEditorAction(editorBlit, description); editorActionManager.Add(action); diff --git a/mods/common/fluent/common.ftl b/mods/common/fluent/common.ftl index 3143942469..0e81313ff8 100644 --- a/mods/common/fluent/common.ftl +++ b/mods/common/fluent/common.ftl @@ -1120,9 +1120,12 @@ keycode = .mouse5 = Mouse 5 ## MapGeneratorToolLogic -label-map-generator-failed-cancel = Dismiss notification-map-generator-generated = Generated using { $name } -notification-map-generator-failed = Map generation failed + +dialog-notification-map-generator-failed = + .title = Map generation failed + .prompt = See debug.log for details. + .cancel = Dismiss ## EditorTilingPathBrush notification-tiling-path-started = Started tiling path