epic/OpenRA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avoid an unneeded loop

Browse Source
This commit is contained in:
Matthias Mailänder
2015-05-31 09:43:35 +02:00
parent a12e6a191b
commit 7186f654d7
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
OpenRA.Mods.Common/Lint/CheckPlayers.cs
View File

@@ -22,22 +22,24 @@ namespace OpenRA.Mods.Common.Lint
var players = new MapPlayers(map.PlayerDefinitions).Players; var players = new MapPlayers(map.PlayerDefinitions).Players;
var playerNames = players.Values.Select(p => p.Name); var playerNames = players.Values.Select(p => p.Name);
foreach (var player in players) foreach (var player in players.Values)
foreach (var ally in player.Value.Allies) {
foreach (var ally in player.Allies)
if (!playerNames.Contains(ally)) if (!playerNames.Contains(ally))
emitError("Allies contains player {0} that is not in list.".F(ally)); emitError("Allies contains player {0} that is not in list.".F(ally));
foreach (var player in players) foreach (var enemy in player.Enemies)
foreach (var enemy in player.Value.Enemies)
if (!playerNames.Contains(enemy)) if (!playerNames.Contains(enemy))
emitError("Enemies contains player {0} that is not in list.".F(enemy)); emitError("Enemies contains player {0} that is not in list.".F(enemy));
}
var worldActor = map.Rules.Actors["world"]; var worldActor = map.Rules.Actors["world"];
var races = worldActor.Traits.WithInterface<CountryInfo>().Select(c => c.Race); var races = worldActor.Traits.WithInterface<CountryInfo>().Select(c => c.Race);
foreach (var player in players) foreach (var player in players.Values)
if (!string.IsNullOrWhiteSpace(player.Value.Race) && player.Value.Race != "Random" && !races.Contains(player.Value.Race)) if (!string.IsNullOrWhiteSpace(player.Race) && player.Race != "Random" && !races.Contains(player.Race))
emitError("Invalid race {0} chosen for player {1}.".F(player.Value.Race, player.Value.Name)); emitError("Invalid race {0} chosen for player {1}.".F(player.Race, player.Name));
if (worldActor.Traits.Contains<MPStartLocationsInfo>()) if (worldActor.Traits.Contains<MPStartLocationsInfo>())
{ {